Skip to content

Conversation

@KevinDing1
Copy link
Contributor

@KevinDing1 KevinDing1 commented Mar 24, 2025

…ssification

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

  • This commit introduces metric telemetry for the /doc, which will be triggered during the code generation process. The new telemetry will:
    1. Record successful and failure generation requests
    2. Track failed requests with specific error types
    3. Enable the setup of client monitoring alarms base on the metric data
  • Improve the error classification for /doc base on /dev's change: telemetry(amazonq): Update /dev error classification logic #5469

These enhancements will provide better insights into client performance

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

messenger.sendUpdatePlaceholder(tabId, newPlaceholder = message("amazonqFeatureDev.placeholder.after_monthly_limit"))
messenger.sendChatInputEnabledMessage(tabId, enabled = true)
messenger.sendMonthlyLimitError(tabId = tabId)
messenger.sendChatInputEnabledMessage(tabId, enabled = false)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is because we should handle the error as /dev did:

@KevinDing1
Copy link
Contributor Author

/retryBuilds

@KevinDing1 KevinDing1 marked this pull request as ready for review March 25, 2025 16:48
@KevinDing1 KevinDing1 requested a review from a team as a code owner March 25, 2025 16:48
@KevinDing1 KevinDing1 marked this pull request as draft March 25, 2025 16:55
@KevinDing1 KevinDing1 marked this pull request as ready for review March 28, 2025 14:17
@KevinDing1 KevinDing1 enabled auto-merge (squash) March 28, 2025 14:19
@KevinDing1 KevinDing1 disabled auto-merge March 31, 2025 14:37
@KevinDing1 KevinDing1 enabled auto-merge (squash) March 31, 2025 14:37
@KevinDing1
Copy link
Contributor Author

/retryBuilds

2 similar comments
@KevinDing1
Copy link
Contributor Author

/retryBuilds

@samgst-amazon
Copy link
Contributor

/retryBuilds

@samgst-amazon samgst-amazon disabled auto-merge March 31, 2025 21:54
@samgst-amazon samgst-amazon merged commit 9fc070a into aws:main Mar 31, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants