fix(251): fix 251 gateway compilation #5514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API signature changed in 251 beta
manodnyab
approved these changes
Mar 26, 2025
Qodana Community for JVM4 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -0,0 +1,10 @@ | |||
| // Copyright 2025 Amazon.com, Inc. or its affiliates. All Rights Reserved. | |||
| // SPDX-License-Identifier: Apache-2.0 | |||
| package compat.com.jetbrains.gateway.thinClientLink | |||
Check notice
Code scanning / QDJVMC
Package name does not match containing directory Note
| import java.net.URI | ||
|
|
||
| fun startNewClient(lifetime: Lifetime, initialLink: URI, remoteIdentity: String?, onStarted: () -> Unit) = | ||
| LinkedClientManager.getInstance().startNewClient(lifetime, initialLink, remoteIdentity, null, onStarted) |
Check warning
Code scanning / QDJVMC
Unstable API Usage Warning
| import java.net.URI | ||
|
|
||
| fun startNewClient(lifetime: Lifetime, initialLink: URI, remoteIdentity: String?, onStarted: () -> Unit) = | ||
| LinkedClientManager.getInstance().startNewClient(lifetime, initialLink, remoteIdentity, null, onStarted) |
Check warning
Code scanning / QDJVMC
Unstable API Usage Warning
| import java.net.URI | ||
|
|
||
| fun startNewClient(lifetime: Lifetime, initialLink: URI, remoteIdentity: String?, onStarted: () -> Unit) = | ||
| LinkedClientManager.getInstance().startNewClient(lifetime, initialLink, remoteIdentity, null, onStarted) |
Check warning
Code scanning / QDJVMC
Unstable API Usage Warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API signature changed in 251 beta
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.