Skip to content

fix(amazonQ): Q LSP add languageID and version to didOpen messages #5536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 8, 2025
Merged

fix(amazonQ): Q LSP add languageID and version to didOpen messages #5536

merged 1 commit into from
Apr 8, 2025

Conversation

@samgst-amazon
Copy link
Contributor

@samgst-amazon samgst-amazon commented Apr 7, 2025

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@samgst-amazon samgst-amazon requested review from a team as code owners April 7, 2025 22:29
@samgst-amazon samgst-amazon changed the base branch from main to feature/q-lsp April 7, 2025 22:29
@github-actions
Copy link

github-actions bot commented Apr 7, 2025

Qodana Community for JVM

18 new problems were found

Inspection name Severity Problems
Usage of redundant or deprecated syntax or deprecated symbols 🔶 Warning 6
Unused symbol 🔶 Warning 6
Unstable API Usage 🔶 Warning 4
Constructor parameter is never used as a property 🔶 Warning 1
Function or property has platform type ◽️ Notice 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@samgst-amazon samgst-amazon merged commit 61c2b5f into feature/q-lsp Apr 8, 2025
13 of 18 checks passed
@samgst-amazon samgst-amazon deleted the samgst/q-lsp-didOpen-filetypes branch April 8, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rli rli rli approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@samgst-amazon @rli