Skip to content

Conversation

@manodnyab
Copy link
Contributor

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions
Copy link

github-actions bot commented Apr 9, 2025

Qodana Community for JVM

3 new problems were found

Inspection name Severity Problems
Unused symbol 🔶 Warning 2
Unused import directive 🔶 Warning 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]


package software.aws.toolkits.jetbrains.services.amazonq.lsp.model.aws.chat

data class ChatResult(

Check warning

Code scanning / QDJVMC

Unused symbol Warning

Class "ChatResult" is never used
val end: Int,
)

data class EncryptedChatResult(

Check warning

Code scanning / QDJVMC

Unused symbol Warning

Class "EncryptedChatResult" is never used
@manodnyab manodnyab marked this pull request as ready for review April 9, 2025 20:18
@manodnyab manodnyab requested review from a team as code owners April 9, 2025 20:18
@manodnyab manodnyab changed the title Set up Flare chat connection amazonq(flareChat): Set up Flare chat connection Apr 9, 2025
Comment on lines +158 to +166
Range(
Position(
0,
0
),
Position(
1,
1
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use real values?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding this as a follow-up

Comment on lines 60 to 69
project.messageBus.connect().subscribe(
AsyncChatUiListener.TOPIC,
object : AsyncChatUiListener {
override fun onChange(message: String) {
runInEdt {
chatPanel.browser?.postChat(message)
}
}
}
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont need messagebus for this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed offline. This will involve moving the toolwindow to shared. Will address this as a part of a new PR

companion object {
private const val WEB_SCRIPT_URI = "http://mynah/js/mynah-ui.js"
// TODO: Switch this to respect the overriden paths too
private val WEB_SCRIPT_URI = ArtifactHelper().getLatestLocalLspArtifact().resolve("amazonq-ui.js").toUri()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will block class loading until we download the lsp artifacts, which is not what we want

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Converted this to a loading screen while the resource is being fetched. Will happen on the creation of a new browser

@manodnyab manodnyab changed the base branch from feature/q-lsp to feature/q-lsp-chat April 10, 2025 20:35
@manodnyab manodnyab changed the title amazonq(flareChat): Set up Flare chat connection feat(amazonQFlareChat): Set up Flare chat connection Apr 10, 2025
import com.fasterxml.jackson.databind.SerializationFeature
import com.fasterxml.jackson.datatype.jsr310.JavaTimeModule
import com.fasterxml.jackson.module.kotlin.jacksonObjectMapper
import com.fasterxml.jackson.module.kotlin.treeToValue

Check warning

Code scanning / QDJVMC

Unused import directive Warning

Unused import directive
Copy link
Contributor

@rli rli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

discussed offline, will address larger items later to unblock other development

@manodnyab
Copy link
Contributor Author

/retryBuilds

@manodnyab manodnyab merged commit 8d4b98f into feature/q-lsp-chat Apr 11, 2025
13 of 18 checks passed
@manodnyab manodnyab deleted the manodnyb/setupChatComponentsWithFlare branch April 11, 2025 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants