-
Notifications
You must be signed in to change notification settings - Fork 273
feat(amazonQFlareChat): Set up Flare chat connection #5545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(amazonQFlareChat): Set up Flare chat connection #5545
Conversation
Qodana Community for JVM3 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
.../jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/webview/Browser.kt
Fixed
Show fixed
Hide fixed
...s-community/src/software/aws/toolkits/jetbrains/services/amazonq/webview/BrowserConnector.kt
Fixed
Show fixed
Hide fixed
...s-community/src/software/aws/toolkits/jetbrains/services/amazonq/webview/BrowserConnector.kt
Fixed
Show fixed
Hide fixed
...c/software/aws/toolkits/jetbrains/services/amazonq/lsp/flareChat/ChatCommunicationManager.kt
Fixed
Show fixed
Hide fixed
|
|
||
| package software.aws.toolkits.jetbrains.services.amazonq.lsp.model.aws.chat | ||
|
|
||
| data class ChatResult( |
Check warning
Code scanning / QDJVMC
Unused symbol Warning
| val end: Int, | ||
| ) | ||
|
|
||
| data class EncryptedChatResult( |
Check warning
Code scanning / QDJVMC
Unused symbol Warning
…Flare' into manodnyb/setupChatComponentsWithFlare
| Range( | ||
| Position( | ||
| 0, | ||
| 0 | ||
| ), | ||
| Position( | ||
| 1, | ||
| 1 | ||
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use real values?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding this as a follow-up
| project.messageBus.connect().subscribe( | ||
| AsyncChatUiListener.TOPIC, | ||
| object : AsyncChatUiListener { | ||
| override fun onChange(message: String) { | ||
| runInEdt { | ||
| chatPanel.browser?.postChat(message) | ||
| } | ||
| } | ||
| } | ||
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dont need messagebus for this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed offline. This will involve moving the toolwindow to shared. Will address this as a part of a new PR
| companion object { | ||
| private const val WEB_SCRIPT_URI = "http://mynah/js/mynah-ui.js" | ||
| // TODO: Switch this to respect the overriden paths too | ||
| private val WEB_SCRIPT_URI = ArtifactHelper().getLatestLocalLspArtifact().resolve("amazonq-ui.js").toUri() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will block class loading until we download the lsp artifacts, which is not what we want
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Converted this to a loading screen while the resource is being fetched. Will happen on the creation of a new browser
...s-community/src/software/aws/toolkits/jetbrains/services/amazonq/webview/BrowserConnector.kt
Outdated
Show resolved
Hide resolved
...s-community/src/software/aws/toolkits/jetbrains/services/amazonq/webview/BrowserConnector.kt
Outdated
Show resolved
Hide resolved
...munity/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/AmazonQLanguageClientImpl.kt
Fixed
Show fixed
Hide fixed
| import com.fasterxml.jackson.databind.SerializationFeature | ||
| import com.fasterxml.jackson.datatype.jsr310.JavaTimeModule | ||
| import com.fasterxml.jackson.module.kotlin.jacksonObjectMapper | ||
| import com.fasterxml.jackson.module.kotlin.treeToValue |
Check warning
Code scanning / QDJVMC
Unused import directive Warning
…Flare' into manodnyb/setupChatComponentsWithFlare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
discussed offline, will address larger items later to unblock other development
|
/retryBuilds |
Types of changes
Description
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.