fix(amazonq): fix LinkageError when starting AmazonQLspService (attempt 2) #5627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qodana Community for JVM1 new problem were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| tree, | ||
| false, | ||
| Function<TreePath, String> { obj -> | ||
| Function<TreePath, String?> { obj -> |
Check notice
Code scanning / QDJVMC
Unnecessary type argument Note
manodnyab
reviewed
Apr 24, 2025
| // Make sure we exclude stuff we either A) ships with IDE, B) we don't use to cut down on size | ||
| runtimeClasspath { | ||
| exclude(group = "org.slf4j") | ||
| exclude(group = "com.google.code.gson") |
There was a problem hiding this comment.
This package is included only in certain environments right but we exclude it in all?
manodnyab
approved these changes
Apr 24, 2025
rli
added a commit
that referenced
this pull request
Apr 25, 2025
rli
added a commit
that referenced
this pull request
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In certain IDE environments, for example when user has the latest Scala plugin, Amazon Q attempts to load lsp4j through
transitive optional dependencies instead of through the IDE.
Ideally we do not bundle the library, but this is not possible until JetBrains can guarantee stronger isolation between plugins
As part of this we optimistically exclude Gson in hopes that it does not have the same issue. SLF4J is additionally packaged due to the same linkage error, though it seems to be pulling in an older version from somewhere else.
We also need to bump the Kotlin version, since there is a bug where Kotlin compiler runs out of memory for some reason if we exclude Gson from the distribution bundle.
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.