fix(amazonq): Switch profiles if not selected in Q chat #5724
Conversation
Qodana Community for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
…into manodnyb/fixSupportedAuthError
| get() = chatPanel.component | ||
|
|
||
| fun disposeAndRecreate() { | ||
| Disposer.dispose(chatPanel) |
There was a problem hiding this comment.
not sure what will happen if we keep creating new panel and they are never disposed, will it cause memory leak (but idk how to test it..)
There was a problem hiding this comment.
yes we would need to dispose if we are creating new panels
| fun disposeAndRecreate() { | ||
| Disposer.dispose(chatPanel) | ||
| fun recreatePanel() { | ||
| chatPanel = AmazonQPanel(project, scope) |
There was a problem hiding this comment.
@manodnyab will it help if we assign the new panel first then dispose the stale one?
There was a problem hiding this comment.
maybe not, just tested
There was a problem hiding this comment.
Removing this part, if 5729 fixes the crash
|
also #5729 |
3 participants
Description
If a user gets Select Q Developer Profile card in chat, check if an active profile already exists and update Flare with the information. If an active profile doesn't, the dialog to change profiles is shown to the user.
Ideally the user should never land in this state since profiles are chosen before the chat window is shown.
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.