Skip to content

Conversation

@bryceitoc9
Copy link
Contributor

@bryceitoc9 bryceitoc9 commented May 20, 2025

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

Use the JetBrains default font for the inline chat popup.

  • Canonical with fonts in other popups (e.g find all, search everywhere), instead of editor font
  • Supports full Unicode fonts in Windows
    • MacOS unaffected

image

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@bryceitoc9 bryceitoc9 requested review from a team as code owners May 20, 2025 15:52
@github-actions
Copy link

github-actions bot commented May 20, 2025

Qodana Community for JVM

1 new problem were found

Inspection name Severity Problems
Unused symbol 🔶 Warning 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@andrewyuq
Copy link
Contributor

is there a screenshot for the visual diff?

@bryceitoc9 bryceitoc9 changed the title Use JetBrains default font for inline chat popup fix: Use JetBrains default font for inline chat popup May 21, 2025
Copy link
Contributor

@manodnyab manodnyab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we merge this to main instead since this feature is in main?

@rli rli changed the base branch from feature/q-lsp-chat to main May 21, 2025 18:03
@rli rli requested review from a team as code owners May 21, 2025 18:03
@rli rli changed the base branch from main to feature/q-lsp-chat May 21, 2025 18:03
@rli rli merged commit d7c43ba into feature/q-lsp-chat May 21, 2025
14 of 19 checks passed
@rli rli deleted the bryceito/inline-chat-font branch May 21, 2025 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants