refactor: move isOpenAndDirty to general utils

Author: Hweinstock

packages/core/src/amazonq/util/files.ts

@@ -299,7 +299,3 @@ export function registerNewFiles(
 
     return result
 }
-
-export function isFileOpenAndDirty(uri: vscode.Uri) {
-    return vscode.workspace.textDocuments.some((document) => document.uri.fsPath === uri.fsPath && document.isDirty)
-}

packages/core/src/codewhisperer/util/zipUtil.ts

@@ -28,7 +28,7 @@ import { ZipStream } from '../../shared/utilities/zipStream'
 import { getTextContent } from '../../shared/utilities/textDocumentUtilities'
 import { ChildProcess, ChildProcessOptions } from '../../shared/utilities/processUtils'
 import { removeAnsi } from '../../shared/utilities/textUtilities'
-import { isFileOpenAndDirty } from '../../amazonq/util/files'
+import { isFileOpenAndDirty } from '../../shared/utilities/vsCodeUtils'
 
 export interface ZipMetadata {
     rootDir: string

packages/core/src/shared/utilities/vsCodeUtils.ts

@@ -254,3 +254,7 @@ export function subscribeOnce<T>(event: vscode.Event<T>): vscode.Event<T> {
         return result
     }
 }
+
+export function isFileOpenAndDirty(uri: vscode.Uri) {
+    return vscode.workspace.textDocuments.some((document) => document.uri.fsPath === uri.fsPath && document.isDirty)
+}

packages/core/src/test/shared/utilities/vscodeUtils.test.ts

@@ -8,6 +8,8 @@ import { VSCODE_EXTENSION_ID } from '../../../shared/extensions'
 import * as vscodeUtil from '../../../shared/utilities/vsCodeUtils'
 import * as vscode from 'vscode'
 import { getExcludePattern } from '../../../shared/fs/watchedFiles'
+import { TestFolder } from '../../testUtil'
+import path from 'path'
 
 describe('vscodeUtils', async function () {
     it('activateExtension(), isExtensionActive()', async function () {
@@ -119,3 +121,20 @@ describe('buildMissingExtensionMessage()', function () {
         )
     })
 })
+
+describe('isOpenAndDirty', function () {
+    it('updates as file status changes ', async function () {
+        const testFolder = await TestFolder.create()
+        await testFolder.write('file1.md', 'test content')
+        const document = await vscode.workspace.openTextDocument(path.join(testFolder.path, '/file1.md'))
+        assert.strictEqual(vscodeUtil.isFileOpenAndDirty(document.uri), false)
+        await vscode.window.showTextDocument(document)
+        assert.strictEqual(vscodeUtil.isFileOpenAndDirty(document.uri), false)
+        await vscode.window.activeTextEditor?.edit((editBuilder) => {
+            editBuilder.insert(new vscode.Position(0, 0), '// a comment\n')
+        })
+        assert.strictEqual(vscodeUtil.isFileOpenAndDirty(document.uri), true)
+        await document.save()
+        assert.strictEqual(vscodeUtil.isFileOpenAndDirty(document.uri), false)
+    })
+})