separate getAppBySpace as a function, add mock to test

Author: PotatoWKY

packages/core/src/awsService/sagemaker/sagemakerSpace.ts

@@ -117,12 +117,8 @@ export class SagemakerSpace {
                 AppType: this.spaceApp?.SpaceSettingsSummary?.AppType,
                 SpaceName: this.spaceApp.SpaceName,
             })
-        } else {
-            const appsList = await this.client
-                .listApps({ DomainIdEquals: this.spaceApp.DomainId, SpaceNameEquals: this.spaceApp.SpaceName })
-                .flatten()
-                .promise()
-            app = appsList[0]
+        } else if (this.spaceApp.DomainId && this.spaceApp.SpaceName) {
+            app = await this.client.getAppBySpace(this.spaceApp.DomainId, this.spaceApp.SpaceName)
         }
 
         // AWS DescribeSpace API returns full details with property names like 'SpaceSettings'

packages/core/src/shared/clients/sagemaker.ts

@@ -126,6 +126,13 @@ export class SagemakerClient extends ClientWrapper<SageMakerClient> {
         return this.makeRequest(DeleteAppCommand, request)
     }
 
+    public async getAppBySpace(domainId: string, spaceName: string): Promise<AppDetails | undefined> {
+        const appsList = await this.listApps({ DomainIdEquals: domainId, SpaceNameEquals: spaceName })
+            .flatten()
+            .promise()
+        return appsList[0]
+    }
+
     public async startSpace(spaceName: string, domainId: string) {
         let spaceDetails: DescribeSpaceCommandOutput
 

packages/core/src/test/awsService/sagemaker/sagemakerSpace.test.ts

@@ -63,6 +63,7 @@ describe('SagemakerSpace', function () {
 
             mockClient.describeSpace.resolves(mockDescribeSpaceResponse)
             mockClient.describeApp.resolves(mockDescribeAppResponse)
+            mockClient.getAppBySpace.resolves(mockDescribeAppResponse)
 
             const space = new SagemakerSpace(mockClient as any, 'us-east-1', mockSpaceApp)
             const updateSpaceSpy = sinon.spy(space, 'updateSpace')