Skip to content

Commit 02f5ef9

Browse files
url: replace node url with whatwg-url (#4271)
whatwg-url is browser and node compatible. We have existing tests that verify things work. Signed-off-by: nkomonen <[email protected]>
1 parent 8a990b7 commit 02f5ef9

File tree

3 files changed

+65
-16
lines changed

3 files changed

+65
-16
lines changed

package-lock.json

Lines changed: 62 additions & 15 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4295,6 +4295,7 @@
42954295
"@types/vscode": "^1.68.0",
42964296
"@types/vscode-webview": "^1.57.1",
42974297
"@types/webpack-env": "^1.18.1",
4298+
"@types/whatwg-url": "^11.0.4",
42984299
"@types/xml2js": "^0.4.11",
42994300
"@typescript-eslint/eslint-plugin": "^5.59.0",
43004301
"@typescript-eslint/parser": "^5.59.1",
@@ -4391,6 +4392,7 @@
43914392
"vscode-nls": "^5.2.0",
43924393
"vue": "^3.3.4",
43934394
"web-tree-sitter": "^0.20.7",
4395+
"whatwg-url": "^14.0.0",
43944396
"winston": "^3.7.1",
43954397
"winston-transport": "^4.5.0",
43964398
"xml2js": "^0.6.0",

src/shared/vscode/uriHandler.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import { getLogger } from '../logger/logger'
88

99
import * as nls from 'vscode-nls'
1010
import { showViewLogsMessage } from '../utilities/messages'
11-
import { URL, URLSearchParams } from 'url'
11+
import { URL, URLSearchParams } from 'whatwg-url'
1212

1313
const localize = nls.loadMessageBundle()
1414

0 commit comments

Comments
 (0)