Set vscode testing window back

Author: opieter-aws

packages/core/src/test/shared/vscode/message.ts

@@ -363,47 +363,42 @@ export class TestFileSystemDialog {
         fs: vscode.FileSystem,
         callback?: (dialog: TestFileSystemDialog) => void
     ): Window['showOpenDialog'] {
-        return async () => undefined
-
-        // return async (options?: vscode.OpenDialogOptions) => {
-        //     const dialog = new TestFileSystemDialog([], { type: 'Open', ...options })
-
-        //     return new Promise<vscode.Uri[] | undefined>((resolve) => {
-        //         dialog.onDidAcceptItem((item) => resolve(item instanceof vscode.Uri ? [item] : item))
-        //         dialog.show()
-        //         callback?.(dialog)
-
-        //         // Auto-close dialog in test environments to prevent hanging
-        //         setTimeout(() => {
-        //             if (dialog.visible) {
-        //                 dialog.close()
-        //             }
-        //         }, 0)
-        //     })
-        // }
+        return async (options?: vscode.OpenDialogOptions) => {
+            const dialog = new TestFileSystemDialog([], { type: 'Open', ...options })
+
+            return new Promise<vscode.Uri[] | undefined>((resolve) => {
+                dialog.onDidAcceptItem((item) => resolve(item instanceof vscode.Uri ? [item] : item))
+                dialog.show()
+                callback?.(dialog)
+
+                // Auto-close dialog in test environments to prevent hanging
+                setTimeout(() => {
+                    if (dialog.visible) {
+                        dialog.close()
+                    }
+                }, 0)
+            })
+        }
     }
 
     public static createShowSaveDialogFn(
         fs: vscode.FileSystem,
         callback?: (dialog: TestFileSystemDialog) => void
     ): Window['showSaveDialog'] {
-        return async () => undefined
-
-        //     return async (options?: vscode.SaveDialogOptions) => {
-        //         const dialog = new TestFileSystemDialog([], { type: 'Save', ...options })
-
-        //         return new Promise<vscode.Uri | undefined>((resolve) => {
-        //             dialog.onDidAcceptItem((item) => resolve(Array.isArray(item) ? item[0] : item))
-        //             dialog.show()
-        //             callback?.(dialog)
-
-        //             setTimeout(() => {
-        //                 if (dialog.visible) {
-        //                     dialog.close()
-        //                 }
-        //             }, 0)
-        //         })
-        //     }
-        // }
+        return async (options?: vscode.SaveDialogOptions) => {
+            const dialog = new TestFileSystemDialog([], { type: 'Save', ...options })
+
+            return new Promise<vscode.Uri | undefined>((resolve) => {
+                dialog.onDidAcceptItem((item) => resolve(Array.isArray(item) ? item[0] : item))
+                dialog.show()
+                callback?.(dialog)
+
+                setTimeout(() => {
+                    if (dialog.visible) {
+                        dialog.close()
+                    }
+                }, 0)
+            })
+        }
     }
 }

packages/core/src/test/shared/vscode/window.ts

@@ -147,10 +147,10 @@ export function createTestWindow(workspace = vscode.workspace): Window & TestWin
         emitters.onDidShowMessage.fire(message)
     }
 
-    // function fireOnDidShowDialog(dialog: TestFileSystemDialog) {
-    //     state.shownDialogs.push(dialog)
-    //     emitters.onDidShowDialog.fire(dialog)
-    // }
+    function fireOnDidShowDialog(dialog: TestFileSystemDialog) {
+        state.shownDialogs.push(dialog)
+        emitters.onDidShowDialog.fire(dialog)
+    }
 
     function fireOnDidShowQuickPick(picker: TestQuickPick) {
         if (!state.shownQuickPicks.includes(picker)) {
@@ -399,14 +399,8 @@ export function createTestWindow(workspace = vscode.workspace): Window & TestWin
         showInformationMessage: TestMessage.createShowMessageFn(SeverityLevel.Information, fireOnDidShowMessage),
         showWarningMessage: TestMessage.createShowMessageFn(SeverityLevel.Warning, fireOnDidShowMessage),
         showErrorMessage: TestMessage.createShowMessageFn(SeverityLevel.Error, fireOnDidShowMessage),
-        showOpenDialog: async (...args) => {
-            console.log('showOpenDialog called with args:', args)
-            return undefined
-        },
-        showSaveDialog: async (...args) => {
-            console.log('showSaveDialog called with args:', args)
-            return undefined
-        },
+        showOpenDialog: TestFileSystemDialog.createOpenSaveDialogFn(workspace.fs, fireOnDidShowDialog),
+        showSaveDialog: TestFileSystemDialog.createShowSaveDialogFn(workspace.fs, fireOnDidShowDialog),
         onError: onErrorEmitter.event,
     }