refactor: use handler wording

Author: Hweinstock

packages/core/src/shared/awsClientBuilderV3.ts

@@ -91,7 +91,7 @@ export class AWSClientBuilderV3 {
         return shim
     }
 
-    private buildHttpClient() {
+    private buildHttpHandler() {
         const requestTimeout = 30000
         // HACK: avoid importing node-http-handler on web.
         return isWeb()
@@ -103,7 +103,7 @@ export class AWSClientBuilderV3 {
               })
     }
 
-    private getHttpClient = once(this.buildHttpClient.bind(this))
+    private getHttpHandler = once(this.buildHttpHandler.bind(this))
 
     private keyAwsService<C extends AwsClient>(serviceOptions: AwsServiceOptions<C>): string {
         // Serializing certain objects in the args allows us to detect when nested objects change (ex. new retry strategy, endpoints)
@@ -148,7 +148,7 @@ export class AWSClientBuilderV3 {
         }
 
         if (!opt.requestHandler) {
-            opt.requestHandler = this.getHttpClient()
+            opt.requestHandler = this.getHttpHandler()
         }
         // TODO: add tests for refresh logic.
         opt.credentials = async () => {

packages/core/src/test/shared/awsClientBuilderV3.test.ts

@@ -78,7 +78,7 @@ describe('AwsClientBuilderV3', function () {
         assert.strictEqual(service.config.userAgent[0][0], 'CUSTOM USER AGENT')
     })
 
-    it('injects http client into client', function () {
+    it('injects http client into handler', function () {
         const requestHandler = new NodeHttpHandler({
             requestTimeout: 1234,
         })
@@ -91,17 +91,18 @@ describe('AwsClientBuilderV3', function () {
         assert.strictEqual(service.config.requestHandler, requestHandler)
     })
 
-    it('defaults to reusing singular http client', function () {
+    it('defaults to reusing singular http handler', function () {
         const service = builder.createAwsService({
             serviceClient: Client,
         })
         const service2 = builder.createAwsService({
             serviceClient: Client,
         })
-        // Check if request handlers are reference-equal.
+
         const firstHandler = service.config.requestHandler
         const secondHandler = service2.config.requestHandler
 
+        // If not injected, the http handler can be undefined before making request.
         if (firstHandler instanceof NodeHttpHandler && secondHandler instanceof NodeHttpHandler) {
             assert.ok(firstHandler === secondHandler)
         } else {