fix(logger): prevent module from blocking activation (#3119)

## Problem
The logging activate function has several fs calls that could potentially cause issues on activation.

## Solution
Don't block on non-critical functionality

Author: JadenSimon

.changes/next-release/Bug Fix-5b67cc43-711c-4d49-9cc0-997f73289d83.json

@@ -0,0 +1,4 @@
+{
+	"type": "Bug Fix",
+	"description": "Improve extension start-up performance, especially on devices with slower file systems"
+}

src/shared/logger/activation.ts

@@ -74,13 +74,18 @@ export async function activate(
     getLogger().debug(`Logging started: ${logUri}`)
 
     const commands = new Logging(logUri, mainLogger)
-    extensionContext.subscriptions.push(
-        ...Object.values(Logging.declared).map(c => c.register(commands)),
-        await createLogWatcher(logUri.fsPath)
-    )
+    extensionContext.subscriptions.push(...Object.values(Logging.declared).map(c => c.register(commands)))
+
+    createLogWatcher(logUri)
+        .then(sub => {
+            extensionContext.subscriptions.push(sub)
+        })
+        .catch(err => {
+            getLogger().warn('Failed to start log file watcher: %s', err)
+        })
 
     cleanLogFiles(path.dirname(logUri.fsPath)).catch(err => {
-        getLogger().warn('Failed to clean-up old logs: %s', (err as Error).message)
+        getLogger().warn('Failed to clean-up old logs: %s', err)
     })
 }
 
@@ -152,25 +157,24 @@ function makeLogFilename(): string {
 /**
  * Watches for renames on the log file and notifies the user.
  */
-async function createLogWatcher(logPath: string): Promise<vscode.Disposable> {
-    const exists = await waitUntil(() => fs.pathExists(logPath), { interval: 1000, timeout: 60000 })
+async function createLogWatcher(logFile: vscode.Uri): Promise<vscode.Disposable> {
+    const exists = await waitUntil(() => SystemUtilities.fileExists(logFile), { interval: 1000, timeout: 60000 })
 
     if (!exists) {
-        getLogger().warn(`Log file ${logPath} does not exist!`)
+        getLogger().warn(`Log file ${logFile.path} does not exist!`)
         return { dispose: () => {} }
     }
 
     let checking = false
     // TODO: fs.watch() has many problems, consider instead:
     //   - https://github.com/paulmillr/chokidar
     //   - https://www.npmjs.com/package/fb-watchman
-    const watcher = fs.watch(logPath, async eventType => {
+    const watcher = fs.watch(logFile.fsPath, async eventType => {
         if (checking || eventType !== 'rename') {
             return
         }
         checking = true
-        const exists = await fs.pathExists(logPath).catch(() => true)
-        if (!exists) {
+        if (!(await SystemUtilities.fileExists(logFile))) {
             vscode.window.showWarningMessage(
                 localize('AWS.log.logFileMove', 'The log file for this session has been moved or deleted.')
             )