remove optional overwrite parameter

Hweinstock · Hweinstock · commit 07c17b24528b · 2024-09-25T16:22:16.000-04:00
diff --git a/packages/core/src/awsService/ec2/sshKeyPair.ts b/packages/core/src/awsService/ec2/sshKeyPair.ts
@@ -28,7 +28,7 @@ export class SshKeyPair {
         })
     }
 
-    public static async getSshKeyPair(keyPath: string, lifetime: number, overwrite: boolean = true) {
+    public static async getSshKeyPair(keyPath: string, lifetime: number) {
         await SshKeyPair.generateSshKeyPair(keyPath)
         return new SshKeyPair(keyPath, lifetime)
     }
diff --git a/packages/core/src/test/awsService/ec2/model.test.ts b/packages/core/src/test/awsService/ec2/model.test.ts
@@ -139,7 +139,7 @@ describe('Ec2ConnectClient', function () {
                 instanceId: 'test-id',
                 region: 'test-region',
             }
-            const mockKeys = await SshKeyPair.getSshKeyPair('fakeDir', 30000, false)
+            const mockKeys = await SshKeyPair.getSshKeyPair('fakeDir', 30000)
             await client.sendSshKeyToInstance(testSelection, mockKeys, 'test-user')
             sinon.assert.calledWith(sendCommandStub, testSelection.instanceId, 'AWS-RunShellScript')
             sinon.restore()

Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ export class SshKeyPair {`
`28`	`28`	`})`
`29`	`29`	`}`
`30`	`30`
`31`		`- public static async getSshKeyPair(keyPath: string, lifetime: number, overwrite: boolean = true) {`
	`31`	`+ public static async getSshKeyPair(keyPath: string, lifetime: number) {`
`32`	`32`	`await SshKeyPair.generateSshKeyPair(keyPath)`
`33`	`33`	`return new SshKeyPair(keyPath, lifetime)`
`34`	`34`	`}`
Original file line number	Diff line number	Diff line change
`@@ -139,7 +139,7 @@ describe('Ec2ConnectClient', function () {`
`139`	`139`	`instanceId: 'test-id',`
`140`	`140`	`region: 'test-region',`
`141`	`141`	`}`
`142`		`- const mockKeys = await SshKeyPair.getSshKeyPair('fakeDir', 30000, false)`
	`142`	`+ const mockKeys = await SshKeyPair.getSshKeyPair('fakeDir', 30000)`
`143`	`143`	`await client.sendSshKeyToInstance(testSelection, mockKeys, 'test-user')`
`144`	`144`	`sinon.assert.calledWith(sendCommandStub, testSelection.instanceId, 'AWS-RunShellScript')`
`145`	`145`	`sinon.restore()`