refactor(core): migrate redshift + stepFunctions + cloudcontrol to aws sdk v3

Author: chungjac

packages/core/src/awsService/redshift/explorer/redshiftWarehouseNode.ts

@@ -15,7 +15,7 @@ import { ChildNodeLoader, ChildNodePage } from '../../../awsexplorer/childNodeLo
 import { DefaultRedshiftClient } from '../../../shared/clients/redshiftClient'
 import { deleteConnection, ConnectionParams, ConnectionType, RedshiftWarehouseType } from '../models/models'
 import { RedshiftNodeConnectionWizard } from '../wizards/connectionWizard'
-import { ListDatabasesResponse } from 'aws-sdk/clients/redshiftdata'
+import { ListDatabasesResponse } from '@aws-sdk/client-redshift-data'
 import { getIcon } from '../../../shared/icons'
 import { AWSCommandTreeNode } from '../../../shared/treeview/nodes/awsCommandTreeNode'
 import { telemetry } from '../../../shared/telemetry/telemetry'

packages/core/src/awsService/redshift/wizards/connectionWizard.ts

@@ -14,7 +14,7 @@ import { DefaultRedshiftClient } from '../../../shared/clients/redshiftClient'
 import { Region } from '../../../shared/regions/endpoints'
 import { RegionProvider } from '../../../shared/regions/regionProvider'
 import { createRegionPrompter } from '../../../shared/ui/common/region'
-import { ClustersMessage } from 'aws-sdk/clients/redshift'
+import { ClustersMessage } from '@aws-sdk/client-redshift'
 import { Prompter } from '../../../shared/ui/prompter'
 import { ListSecretsResponse } from '@aws-sdk/client-secrets-manager'
 import { SecretsManagerClient } from '../../../shared/clients/secretsManagerClient'

packages/core/src/dynamicResources/commands/saveResource.ts

@@ -13,7 +13,7 @@ import { ResourceNode } from '../explorer/nodes/resourceNode'
 import { ResourceTypeNode } from '../explorer/nodes/resourceTypeNode'
 import { AwsResourceManager } from '../awsResourceManager'
 import { CloudControlClient } from '../../shared/clients/cloudControl'
-import { CloudControl } from 'aws-sdk'
+import { ResourceDescription } from '@aws-sdk/client-cloudcontrol'
 import globals from '../../shared/extensionGlobals'
 import { telemetry } from '../../shared/telemetry/telemetry'
 
@@ -224,7 +224,7 @@ export async function updateResource(
     )
 }
 
-function computeDiff(currentDefinition: CloudControl.ResourceDescription, updatedDefinition: string): Operation[] {
+function computeDiff(currentDefinition: ResourceDescription, updatedDefinition: string): Operation[] {
     const current = JSON.parse(currentDefinition.Properties!)
     const updated = JSON.parse(updatedDefinition)
     return compare(current, updated)

packages/core/src/dynamicResources/explorer/nodes/resourceTypeNode.ts

@@ -15,7 +15,7 @@ import { localize } from '../../../shared/utilities/vsCodeUtils'
 import { ResourcesNode } from './resourcesNode'
 import { ResourceNode } from './resourceNode'
 import { Result } from '../../../shared/telemetry/telemetry'
-import { CloudControl } from 'aws-sdk'
+import { ResourceDescription } from '@aws-sdk/client-cloudcontrol'
 import { ResourceTypeMetadata } from '../../model/resources'
 import { S3Client } from '../../../shared/clients/s3'
 import { telemetry } from '../../../shared/telemetry/telemetry'
@@ -123,15 +123,12 @@ export class ResourceTypeNode extends AWSTreeNodeBase implements LoadMoreNode {
             })
 
             newResources = response.ResourceDescriptions
-                ? response.ResourceDescriptions.reduce(
-                      (accumulator: ResourceNode[], current: CloudControl.ResourceDescription) => {
-                          if (current.Identifier) {
-                              accumulator.push(new ResourceNode(this, current.Identifier, this.childContextValue))
-                          }
-                          return accumulator
-                      },
-                      []
-                  )
+                ? response.ResourceDescriptions.reduce((accumulator: ResourceNode[], current: ResourceDescription) => {
+                      if (current.Identifier) {
+                          accumulator.push(new ResourceNode(this, current.Identifier, this.childContextValue))
+                      }
+                      return accumulator
+                  }, [])
                 : []
             nextToken = response.NextToken
         }

packages/core/src/stepFunctions/workflowStudio/types.ts

@@ -2,8 +2,8 @@
  * Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
  * SPDX-License-Identifier: Apache-2.0
  */
-import { IAM } from 'aws-sdk'
-import * as StepFunctions from '@aws-sdk/client-sfn'
+import { ListRolesCommandInput } from '@aws-sdk/client-iam'
+import { TestStateInput } from '@aws-sdk/client-sfn'
 import * as vscode from 'vscode'
 
 export enum WorkflowMode {
@@ -94,8 +94,8 @@ export enum ApiAction {
 }
 
 type ApiCallRequestMapping = {
-    [ApiAction.IAMListRoles]: IAM.ListRolesRequest
-    [ApiAction.SFNTestState]: StepFunctions.TestStateInput
+    [ApiAction.IAMListRoles]: ListRolesCommandInput
+    [ApiAction.SFNTestState]: TestStateInput
 }
 
 interface ApiCallRequestMessageBase<ApiName extends ApiAction> extends Message {

packages/core/src/test/dynamicResources/explorer/resourceTypeNode.test.ts

@@ -13,7 +13,7 @@ import {
     assertNodeListOnlyHasPlaceholderNode,
 } from '../../utilities/explorerNodeAssertions'
 import { CloudControlClient } from '../../../shared/clients/cloudControl'
-import { CloudControl } from 'aws-sdk'
+import { ResourceDescription } from '@aws-sdk/client-cloudcontrol'
 import { ResourceTypeMetadata } from '../../../dynamicResources/model/resources'
 import sinon from 'sinon'
 
@@ -183,7 +183,7 @@ describe('ResourceTypeNode', function () {
         cloudControl.listResources = sinon.stub().resolves({
             TypeName: fakeTypeName,
             NextToken: undefined,
-            ResourceDescriptions: resourceIdentifiers.map<CloudControl.ResourceDescription>((identifier) => {
+            ResourceDescriptions: resourceIdentifiers.map<ResourceDescription>((identifier) => {
                 return {
                     Identifier: identifier,
                     ResourceModel: '',