add test for cmd outside workspace

Author: Randall-Jiang

packages/core/src/codewhispererChat/tools/executeBash.ts

@@ -189,31 +189,34 @@ export class ExecuteBash {
                 if (cmdArgs.length === 0) {
                     return { requiresAcceptance: true }
                 }
+
+                const command = cmdArgs[0]
+                const category = commandCategories.get(command)
                 let hasOutsideWorkspacePath = false
-                // For each command, validate arguments for path safety within workspace
+
                 for (const arg of cmdArgs) {
                     if (this.looksLikePath(arg)) {
                         let fullPath = arg
                         if (!path.isAbsolute(arg) && this.workingDirectory) {
                             fullPath = path.join(this.workingDirectory, arg)
                         }
+
                         const workspaceFolders = vscode.workspace.workspaceFolders
                         if (!workspaceFolders || workspaceFolders.length === 0) {
                             hasOutsideWorkspacePath = true
-                            continue
+                            break
                         }
+
                         const isInWorkspace = workspaceFolders.some((folder) =>
                             isInDirectory(folder.uri.fsPath, fullPath)
                         )
                         if (!isInWorkspace) {
                             hasOutsideWorkspacePath = true
+                            break
                         }
                     }
                 }
 
-                const command = cmdArgs[0]
-                const category = commandCategories.get(command)
-
                 switch (category) {
                     case CommandCategory.Destructive:
                         return { requiresAcceptance: true, warning: destructiveCommandWarningMessage }
@@ -228,6 +231,7 @@ export class ExecuteBash {
                         return { requiresAcceptance: true }
                 }
             }
+
             return { requiresAcceptance: false }
         } catch (error) {
             this.logger.warn(`Error while checking acceptance: ${(error as Error).message}`)

packages/core/src/test/codewhispererChat/tools/executeBash.test.ts

@@ -54,6 +54,16 @@ describe('ExecuteBash Tool', () => {
         )
     })
 
+    it('requiresAcceptance=true without destructive warning for read-only command outside workspace', () => {
+        const execBash = new ExecuteBash({
+            command: 'ls /',
+            cwd: '/do/not/exist/dir',
+        })
+        const result = execBash.requiresAcceptance()
+        assert.equal(result.requiresAcceptance, true, 'Should require acceptance due to path outside workspace')
+        assert.equal(result.warning, undefined, 'Should not show destructive warning for read-only command')
+    })
+
     it('set requiresAcceptance=false if it is a read-only command', () => {
         const execBash = new ExecuteBash({ command: 'cat file.txt' })
         const needsAcceptance = execBash.requiresAcceptance().requiresAcceptance