Commit 0bd3e12
authored
fix(lsp): LSP download timeout message disappears too early (#7145)
## Problem:
When downloading the LSP artifacts from the manifest, there are some
large ones (100+ MB).
For a slow connection this can take 1+ minutes, but our timeout for the
"downloading" message
is set to disappear much earlier. So it is still downloading in the
background, but the message
has disappeared and the user thinks that the download is done.
## Solution:
Increase the timeout to 30 minutes, which will ensure the downloading
message sticks around
while the download is still happening.
## Additional
In another commit this fixes a separate HTTP client bug where it would
time out a request if it took longer than 3 seconds.
This caused downloads to be aborted (separate from the download message
disappearing). Now it times out after 30 minutes.
---
- Treat all work as PUBLIC. Private `feature/x` branches will not be
squash-merged at release time.
- Your code changes must meet the guidelines in
[CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines).
- License: I confirm that my contribution is made under the terms of the
Apache 2.0 license.
Signed-off-by: nkomonen-amazon <[email protected]>1 parent 4ba5251 commit 0bd3e12
File tree
1 file changed
+4
-2
lines changed1 file changed
+4
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
| 18 | + | |
18 | 19 | | |
19 | | - | |
20 | | - | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
21 | 23 | | |
22 | 24 | | |
23 | 25 | | |
| |||
0 commit comments