Skip to content

Commit 0f24dcc

Browse files
authored
fix(amazonq transform): messages to chat get lost #4949
Problem: Messages get lost in the code path where customers do not need to provide a JAVA_HOME. This leads to missing chat bubbles for: 1. "Building your project" 2. "I was able to build your project" 3. "I am starting to transform your code" Solution: Issue was due to typo when translating `tabId` to `tabID`. Search in the code shows that `tabID` is 10x more common than `tabId` so aligning Q Code Transform to this format. After aligning the usages the missing messages are shown again and are animated where required.
1 parent d6971fe commit 0f24dcc

File tree

4 files changed

+14
-10
lines changed

4 files changed

+14
-10
lines changed
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
{
2+
"type": "Bug Fix",
3+
"description": "Amazon Q Code Transform: Show additional status messages to align with experience when JAVA_HOME set incorrectly."
4+
}

packages/core/src/amazonq/webview/ui/apps/gumbyChatConnector.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,7 @@ export class Connector {
166166
action: action.id,
167167
formSelectedValues: action.formItemValues,
168168
tabType: 'gumby',
169-
tabId: tabId,
169+
tabID: tabId,
170170
})
171171
}
172172

packages/core/src/amazonqGumby/chat/controller/controller.ts

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -214,18 +214,18 @@ export class GumbyController {
214214
await this.initiateTransformationOnProject(message)
215215
break
216216
case ButtonActions.CANCEL_TRANSFORMATION_FORM:
217-
this.messenger.sendJobFinishedMessage(message.tabId, CodeWhispererConstants.jobCancelledChatMessage)
217+
this.messenger.sendJobFinishedMessage(message.tabID, CodeWhispererConstants.jobCancelledChatMessage)
218218
break
219219
case ButtonActions.VIEW_TRANSFORMATION_HUB:
220220
await vscode.commands.executeCommand(GumbyCommands.FOCUS_TRANSFORMATION_HUB)
221-
this.messenger.sendJobSubmittedMessage(message.tabId)
221+
this.messenger.sendJobSubmittedMessage(message.tabID)
222222
break
223223
case ButtonActions.STOP_TRANSFORMATION_JOB:
224224
await stopTransformByQ(transformByQState.getJobId(), CancelActionPositions.Chat)
225225
break
226226
case ButtonActions.CONFIRM_START_TRANSFORMATION_FLOW:
227227
this.messenger.sendCommandMessage({ ...message, command: GumbyCommands.CLEAR_CHAT })
228-
await this.transformInitiated({ ...message, tabID: message.tabId })
228+
await this.transformInitiated(message)
229229
break
230230
}
231231
}
@@ -243,10 +243,10 @@ export class GumbyController {
243243
const fromJDKVersion: JDKVersion = message.formSelectedValues['GumbyTransformJdkFromForm']
244244

245245
const projectName = path.basename(pathToProject)
246-
this.messenger.sendProjectSelectionMessage(projectName, fromJDKVersion, toJDKVersion, message.tabId)
246+
this.messenger.sendProjectSelectionMessage(projectName, fromJDKVersion, toJDKVersion, message.tabID)
247247

248248
if (fromJDKVersion === JDKVersion.UNSUPPORTED) {
249-
this.messenger.sendRetryableErrorResponse('unsupported-source-jdk-version', message.tabId)
249+
this.messenger.sendRetryableErrorResponse('unsupported-source-jdk-version', message.tabID)
250250
return
251251
}
252252

@@ -299,9 +299,9 @@ export class GumbyController {
299299
} catch (err: any) {
300300
if (err instanceof JavaHomeNotSetError) {
301301
this.sessionStorage.getSession().conversationState = ConversationState.PROMPT_JAVA_HOME
302-
this.messenger.sendStaticTextResponse('java-home-not-set', message.tabId)
303-
this.messenger.sendChatInputEnabled(message.tabId, true)
304-
this.messenger.sendUpdatePlaceholder(message.tabId, 'Enter the path to your Java installation.')
302+
this.messenger.sendStaticTextResponse('java-home-not-set', message.tabID)
303+
this.messenger.sendChatInputEnabled(message.tabID, true)
304+
this.messenger.sendUpdatePlaceholder(message.tabID, 'Enter the path to your Java installation.')
305305
return
306306
}
307307
throw err

packages/core/src/amazonqGumby/chat/controller/messenger/messenger.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -329,7 +329,7 @@ export class Messenger {
329329
}
330330

331331
public sendCommandMessage(message: any) {
332-
this.dispatcher.sendCommandMessage(new SendCommandMessage(message.command, message.tabId, message.eventId))
332+
this.dispatcher.sendCommandMessage(new SendCommandMessage(message.command, message.tabID, message.eventId))
333333
}
334334

335335
public sendJobFinishedMessage(tabID: string, message: string = '') {

0 commit comments

Comments
 (0)