fix: avoid duplicating error in the logs

Author: Hweinstock

packages/core/src/shared/awsClientBuilderV3.ts

@@ -263,7 +263,7 @@ export async function onDeserialize<Input extends object, Output extends object>
             const err = { ...e, name: e.name, mesage: e.message }
             delete err['stack']
             recordErrorTelemetry(err, serviceId)
-            getLogger().error(`API Error %s: %O`, logTail, err)
+            getLogger().warn(`API Request %s resulted in error: %O`, logTail, err)
         }
         throw e
     }

packages/core/src/shared/clients/clientWrapper.ts

@@ -63,15 +63,15 @@ export abstract class ClientWrapper<C extends AwsClient> implements vscode.Dispo
                 const errWithoutStack = { ...e, name: e.name, message: e.message }
                 delete errWithoutStack['stack']
                 const timecost = perflog.elapsed().toFixed(1)
-                getLogger().error(
-                    `${action} failed (time: %dms) \nparams: %O\nerror: %O`,
-                    timecost,
-                    truncateProps(commandOptions, 20, ['nextToken']),
-                    errWithoutStack
-                )
                 if (requestOptions?.fallbackValue) {
                     return requestOptions.fallbackValue
                 }
+                // Error is already logged in middleware before this, so we omit it here.
+                getLogger().error(
+                    `${action} failed without fallback (time: %dms) \nparams: %O`,
+                    timecost,
+                    truncateProps(commandOptions, 20, ['nextToken'])
+                )
                 throw new ToolkitError(`${action}: ${errWithoutStack.message}`, {
                     code: extractCode(errWithoutStack),
                     cause: errWithoutStack,

packages/core/src/test/shared/awsClientBuilderV3.test.ts

@@ -244,7 +244,7 @@ describe('AwsClientBuilderV3', function () {
             await telemetry.vscode_executeCommand.run(async (_span) => {
                 await assert.rejects(onDeserialize(next, context, args))
             })
-            assertLogsContain('test error', false, 'error')
+            assertLogsContain('test error', false, 'warn')
             assertTelemetry('vscode_executeCommand', { requestServiceType: 'foo' })
         })
 

packages/core/src/testE2E/codecatalyst/client.test.ts

@@ -88,7 +88,7 @@ let projectName: CodeCatalystProject['name']
  *     integ tests, but using the ssh hostname that we get from
  *     {@link prepareDevEnvConnection}.
  */
-describe.only('Test how this codebase uses the CodeCatalyst API', function () {
+describe('Test how this codebase uses the CodeCatalyst API', function () {
     let client: CodeCatalystClient
     let commands: CodeCatalystCommands
     let webviewClient: CodeCatalystCreateWebview