test/changelog

Author: roger-zhangg

packages/core/src/lambda/remoteDebugging/ldkClient.ts

@@ -401,7 +401,7 @@ export class LdkClient {
     }
 
     async deleteDebugVersion(functionArn: string, qualifier: string) {
-        if (!qualifier || qualifier === '$LATEST'){
+        if (!qualifier || qualifier === '$LATEST') {
             // avoid deleting function directly
             return true
         }

packages/core/src/test/lambda/remoteDebugging/ldkClient.test.ts

@@ -348,6 +348,24 @@ describe('LdkClient', () => {
             assert(mockLambdaClient.deleteFunction.calledOnce, 'Should call deleteFunction')
         })
 
+        it('should skip deletion when qualifier is empty or latest', async () => {
+            const result = await ldkClient.deleteDebugVersion(
+                'arn:aws:lambda:us-east-1:123456789012:function:testFunction',
+                ''
+            )
+
+            const result2 = await ldkClient.deleteDebugVersion(
+                'arn:aws:lambda:us-east-1:123456789012:function:testFunction',
+                '$LATEST'
+            )
+            assert.strictEqual(result, true, 'Should return true without attempting deletion when empty')
+            assert.strictEqual(result2, true, 'Should return true without attempting deletion when latest')
+            assert(
+                mockLambdaClient.deleteFunction.notCalled,
+                'Should not call deleteFunction when qualifier is empty or latest'
+            )
+        })
+
         it('should handle version deletion errors', async () => {
             mockLambdaClient.deleteFunction.rejects(new Error('Delete failed'))
 

packages/toolkit/.changes/next-release/Bug Fix-275be675-3247-4d5a-a82d-0ce864bb1274.json

@@ -0,0 +1,4 @@
+{
+	"type": "Bug Fix",
+	"description": "Remote debugging will not delete lambda function by accident if publish version failed"
+}