fix(settings): only migrate telemtry setting if we are in amazon q (#4896)

hayemaxi · web-flow · commit 13103fac202c · 2024-04-30T12:48:24.000-07:00
We attempt to migrate in both extensions, even though we should only do so in the amazon q setting. The toolkit attempt fails, but it still pollutes the state with the stored keys.
This isn't expected to have an effect because the states of the 2 exts are presumed to be separate, but maybe there is a subtle bug revolving around stating here.
diff --git a/packages/core/src/shared/telemetry/util.ts b/packages/core/src/shared/telemetry/util.ts
@@ -59,7 +59,7 @@ export class TelemetryConfig {
     }
 
     public async initAmazonQSetting() {
-        if (globals.context.globalState.get<boolean>(this.amazonQSettingMigratedKey)) {
+        if (!isAmazonQ() || globals.context.globalState.get<boolean>(this.amazonQSettingMigratedKey)) {
             return
         }
         // aws.telemetry isn't deprecated, we are just initializing amazonQ.telemetry with its value.

Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ export class TelemetryConfig {`
`59`	`59`	`}`
`60`	`60`
`61`	`61`	`public async initAmazonQSetting() {`
`62`		`- if (globals.context.globalState.get<boolean>(this.amazonQSettingMigratedKey)) {`
	`62`	`+ if (!isAmazonQ() \|\| globals.context.globalState.get<boolean>(this.amazonQSettingMigratedKey)) {`
`63`	`63`	`return`
`64`	`64`	`}`
`65`	`65`	`// aws.telemetry isn't deprecated, we are just initializing amazonQ.telemetry with its value.`