rename createBucketNamePrompter

Author: vicheey

packages/core/src/shared/sam/deploy.ts

@@ -22,7 +22,7 @@ import { CancellationError } from '../utilities/timeoutUtils'
 import { Wizard } from '../wizards/wizard'
 import { addTelemetryEnvVar } from './cli/samCliInvokerUtils'
 import { validateSamDeployConfig, SamConfig, writeSamconfigGlobal } from './config'
-import { BucketSource, createBucketSourcePrompter, createBucketPrompter } from '../ui/sam/bucketPrompter'
+import { BucketSource, createBucketSourcePrompter, createBucketNamePrompter } from '../ui/sam/bucketPrompter'
 import { createStackPrompter } from '../ui/sam/stackPrompter'
 import { TemplateItem, createTemplatePrompter } from '../ui/sam/templatePrompter'
 import { getProjectRoot, getRecentResponse, getSamCliPathAndVersion, getSource, updateRecentResponse } from './utils'
@@ -109,7 +109,7 @@ export class DeployWizard extends Wizard<DeployParams> {
                     paramsSource === ParamsSource.Specify || paramsSource === ParamsSource.SpecifyAndSave,
             })
             this.form.bucketName.bindPrompter(
-                ({ region }) => createBucketPrompter(new DefaultS3Client(region!), deployMementoRootKey),
+                ({ region }) => createBucketNamePrompter(new DefaultS3Client(region!), deployMementoRootKey),
                 {
                     showWhen: ({ bucketSource }) => bucketSource === BucketSource.UserProvided,
                 }
@@ -135,7 +135,7 @@ export class DeployWizard extends Wizard<DeployParams> {
                     paramsSource === ParamsSource.Specify || paramsSource === ParamsSource.SpecifyAndSave,
             })
             this.form.bucketName.bindPrompter(
-                ({ region }) => createBucketPrompter(new DefaultS3Client(region!), deployMementoRootKey),
+                ({ region }) => createBucketNamePrompter(new DefaultS3Client(region!), deployMementoRootKey),
                 {
                     showWhen: ({ bucketSource }) => bucketSource === BucketSource.UserProvided,
                 }
@@ -168,7 +168,7 @@ export class DeployWizard extends Wizard<DeployParams> {
                     paramsSource === ParamsSource.Specify || paramsSource === ParamsSource.SpecifyAndSave,
             })
             this.form.bucketName.bindPrompter(
-                ({ region }) => createBucketPrompter(new DefaultS3Client(region!), deployMementoRootKey),
+                ({ region }) => createBucketNamePrompter(new DefaultS3Client(region!), deployMementoRootKey),
                 {
                     showWhen: ({ bucketSource }) => bucketSource === BucketSource.UserProvided,
                 }
@@ -198,7 +198,7 @@ export class DeployWizard extends Wizard<DeployParams> {
                     paramsSource === ParamsSource.Specify || paramsSource === ParamsSource.SpecifyAndSave,
             })
             this.form.bucketName.bindPrompter(
-                ({ region }) => createBucketPrompter(new DefaultS3Client(region!), deployMementoRootKey),
+                ({ region }) => createBucketNamePrompter(new DefaultS3Client(region!), deployMementoRootKey),
                 {
                     showWhen: ({ bucketSource }) => bucketSource === BucketSource.UserProvided,
                 }

packages/core/src/shared/sam/sync.ts

@@ -49,7 +49,7 @@ import { TemplateItem, createTemplatePrompter } from '../ui/sam/templatePrompter
 import { createStackPrompter } from '../ui/sam/stackPrompter'
 import { ParamsSource, createSyncParamsSourcePrompter } from '../ui/sam/paramsSourcePrompter'
 import { createEcrPrompter } from '../ui/sam/ecrPrompter'
-import { BucketSource, createBucketPrompter } from '../ui/sam/bucketPrompter'
+import { BucketSource, createBucketNamePrompter } from '../ui/sam/bucketPrompter'
 import { runInTerminal } from './processTerminal'
 
 export interface SyncParams {
@@ -175,7 +175,7 @@ export class SyncWizard extends Wizard<SyncParams> {
         )
 
         this.form.bucketName.bindPrompter(
-            ({ region }) => createBucketPrompter(new DefaultS3Client(region!), syncMementoRootKey),
+            ({ region }) => createBucketNamePrompter(new DefaultS3Client(region!), syncMementoRootKey),
             {
                 showWhen: ({ paramsSource }) =>
                     paramsSource === ParamsSource.Specify || paramsSource === ParamsSource.SpecifyAndSave,

packages/core/src/shared/ui/sam/bucketPrompter.ts

@@ -37,7 +37,7 @@ export function createBucketSourcePrompter() {
     })
 }
 
-export function createBucketPrompter(client: DefaultS3Client, mementoRootKey: string) {
+export function createBucketNamePrompter(client: DefaultS3Client, mementoRootKey: string) {
     const recentBucket = getRecentResponse(mementoRootKey, client.regionCode, 'bucketName')
     const items = client.listBucketsIterable().map((b) => [
         {

packages/core/src/test/shared/ui/sam/bucketPrompter.test.ts

@@ -8,11 +8,11 @@ import { S3 } from 'aws-sdk'
 import sinon from 'sinon'
 import { DefaultS3Client } from '../../../../shared/clients/s3Client'
 import * as SamUtilsModule from '../../../../shared/sam/utils'
-import { createBucketPrompter } from '../../../../shared/ui/sam/bucketPrompter'
+import { createBucketNamePrompter } from '../../../../shared/ui/sam/bucketPrompter'
 import { AsyncCollection } from '../../../../shared/utilities/asyncCollection'
 import { RequiredProps } from '../../../../shared/utilities/tsUtils'
 
-describe('createBucketPrompter', () => {
+describe('createBucketNamePrompter', () => {
     let sandbox: sinon.SinonSandbox
     const s3Client = new DefaultS3Client('us-east-1', 'aws')
     const mementoRootKey = 'samcli.deploy.params'
@@ -39,7 +39,7 @@ describe('createBucketPrompter', () => {
         sandbox.stub(SamUtilsModule, 'getRecentResponse').returns(undefined) // Mock recent bucket
 
         // Act
-        const prompter = createBucketPrompter(s3Client, mementoRootKey)
+        const prompter = createBucketNamePrompter(s3Client, mementoRootKey)
 
         // Assert
         assert.ok(stub.calledOnce)
@@ -63,7 +63,7 @@ describe('createBucketPrompter', () => {
         sandbox.stub(SamUtilsModule, 'getRecentResponse').returns(undefined) // Mock recent bucket
 
         // Act
-        const prompter = createBucketPrompter(s3Client, mementoRootKey)
+        const prompter = createBucketNamePrompter(s3Client, mementoRootKey)
 
         // Assert
         assert.ok(stub.calledOnce)