feat: implement shared http client

Author: Hweinstock

package-lock.json

@@ -521,6 +521,7 @@
         "@smithy/service-error-classification": "^3.0.0",
         "@smithy/shared-ini-file-loader": "^3.0.0",
         "@smithy/util-retry": "^3.0.0",
+        "@smithy/node-http-handler": "^3.0.0",
         "@vscode/debugprotocol": "^1.57.0",
         "@zip.js/zip.js": "^2.7.41",
         "adm-zip": "^0.5.10",

packages/core/package.json

@@ -25,6 +25,7 @@ import {
     RetryStrategy,
     UserAgent,
 } from '@aws-sdk/types'
+import { NodeHttpHandler } from '@smithy/node-http-handler'
 import { HttpResponse, HttpRequest } from '@aws-sdk/protocol-http'
 import { ConfiguredRetryStrategy } from '@smithy/util-retry'
 import { telemetry } from './telemetry/telemetry'
@@ -33,6 +34,8 @@ import { extensionVersion } from './vscode/env'
 import { getLogger } from './logger/logger'
 import { partialClone } from './utilities/collectionUtils'
 import { selectFrom } from './utilities/tsUtils'
+import { Agent } from 'http'
+import { once } from './utilities/functionUtils'
 
 export type AwsClientConstructor<C> = new (o: AwsClientOptions) => C
 
@@ -88,6 +91,16 @@ export class AWSClientBuilderV3 {
         return shim
     }
 
+    private buildHttpClient() {
+        return new NodeHttpHandler({
+            httpAgent: new Agent({ keepAlive: true, timeout: 30000 }),
+            httpsAgent: new Agent({ keepAlive: true, timeout: 30000 }),
+            logger: getLogger(),
+        })
+    }
+
+    private getHttpClient = once(this.buildHttpClient.bind(this))
+
     private keyAwsService<C extends AwsClient>(serviceOptions: AwsServiceOptions<C>): string {
         // Serializing certain objects in the args allows us to detect when nested objects change (ex. new retry strategy, endpoints)
         return [
@@ -129,6 +142,10 @@ export class AWSClientBuilderV3 {
             // Simple exponential backoff strategy as default.
             opt.retryStrategy = new ConfiguredRetryStrategy(5, (attempt: number) => 1000 * 2 ** attempt)
         }
+
+        if (!opt.requestHandler) {
+            opt.requestHandler = this.getHttpClient()
+        }
         // TODO: add tests for refresh logic.
         opt.credentials = async () => {
             const creds = await shim.get()

packages/core/src/shared/awsClientBuilderV3.ts

@@ -32,6 +32,7 @@ import { Credentials, MetadataBearer, MiddlewareStack } from '@aws-sdk/types'
 import { oneDay } from '../../shared/datetime'
 import { ConfiguredRetryStrategy } from '@smithy/util-retry'
 import { StandardRetryStrategy } from '@smithy/util-retry'
+import { NodeHttpHandler } from '@smithy/node-http-handler'
 
 describe('AwsClientBuilderV3', function () {
     let builder: AWSClientBuilderV3
@@ -77,6 +78,37 @@ describe('AwsClientBuilderV3', function () {
         assert.strictEqual(service.config.userAgent[0][0], 'CUSTOM USER AGENT')
     })
 
+    it('injects http client into client', async function () {
+        const requestHandler = new NodeHttpHandler({
+            requestTimeout: 1234,
+        })
+        const service = await builder.createAwsService({
+            serviceClient: Client,
+            clientOptions: {
+                requestHandler: requestHandler,
+            },
+        })
+        assert.strictEqual(service.config.requestHandler, requestHandler)
+    })
+
+    it('defaults to same http client', async function () {
+        const service = await builder.createAwsService({
+            serviceClient: Client,
+        })
+        const service2 = await builder.createAwsService({
+            serviceClient: Client,
+        })
+        // Check if request handlers are reference-equal.
+        const firstHandler = service.config.requestHandler
+        const secondHandler = service2.config.requestHandler
+
+        if (firstHandler instanceof NodeHttpHandler && secondHandler instanceof NodeHttpHandler) {
+            assert.ok(firstHandler === secondHandler)
+        } else {
+            assert.fail('Expected both request handlers to be NodeHttpHandler instances')
+        }
+    })
+
     describe('caching mechanism', function () {
         it('avoids recreating client on duplicate calls', async function () {
             const firstClient = await builder.getAwsService({ serviceClient: TestClient })