Skip to content

Commit 1760019

Browse files
committed
feat(amazonq): disable generating message while waiting for inline suggestion
1 parent 7b161da commit 1760019

File tree

3 files changed

+10
-5
lines changed

3 files changed

+10
-5
lines changed
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
{
2+
"type": "Feature",
3+
"description": "disable generating message while waiting for inline suggestion"
4+
}

packages/amazonq/src/app/inline/recommendationService.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,8 @@ export class RecommendationService {
6565
try {
6666
// Show UI indicators only if UI is enabled
6767
if (options.showUi) {
68-
await this.inlineGeneratingMessage.showGenerating(context.triggerKind)
68+
// uncomment the below line to re-enable generating message
69+
// await this.inlineGeneratingMessage.showGenerating(context.triggerKind)
6970
await statusBar.setLoading()
7071
}
7172

@@ -149,7 +150,7 @@ export class RecommendationService {
149150
} finally {
150151
// Remove all UI indicators if UI is enabled
151152
if (options.showUi) {
152-
this.inlineGeneratingMessage.hideGenerating()
153+
// this.inlineGeneratingMessage.hideGenerating()
153154
void statusBar.refreshStatusBar() // effectively "stop loading"
154155
}
155156
}

packages/amazonq/test/unit/amazonq/apps/inline/recommendationService.test.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -274,7 +274,7 @@ describe('RecommendationService', () => {
274274
})
275275

276276
it('should show UI indicators when showUi option is true (default)', async () => {
277-
const { showGeneratingStub, hideGeneratingStub } = setupUITest()
277+
// const { showGeneratingStub, hideGeneratingStub } = setupUITest()
278278

279279
// Call with default options (showUi: true)
280280
await service.getAllRecommendations(
@@ -287,8 +287,8 @@ describe('RecommendationService', () => {
287287
)
288288

289289
// Verify UI methods were called
290-
sinon.assert.calledOnce(showGeneratingStub)
291-
sinon.assert.calledOnce(hideGeneratingStub)
290+
// sinon.assert.calledOnce(showGeneratingStub)
291+
// sinon.assert.calledOnce(hideGeneratingStub)
292292
sinon.assert.calledOnce(statusBarStub.setLoading)
293293
sinon.assert.calledOnce(statusBarStub.refreshStatusBar)
294294
})

0 commit comments

Comments
 (0)