feat(codewhisperer): remove IntelliSense and assign user group (#3504)

* removes IntelliSense trigger
* divide users into 3 user groups for A/B

Author: zixlin7

.changes/next-release/Feature-0a157c53-8327-489a-8d6f-ec7610d5c946.json

@@ -0,0 +1,4 @@
+{
+	"type": "Feature",
+	"description": "CodeWhisperer no longer trigger suggestions on IntelliSense acceptance"
+}

src/codewhisperer/activation.ts

@@ -62,7 +62,7 @@ export async function activate(context: ExtContext): Promise<void> {
     if (isCloud9()) {
         await enableDefaultConfigCloud9()
     } else {
-        determineIsClassifierEnabled()
+        determineUserGroup()
     }
     /**
      * CodeWhisperer security panel
@@ -214,13 +214,20 @@ export async function activate(context: ExtContext): Promise<void> {
         )
     }
 
-    function determineIsClassifierEnabled() {
-        const isClassifierEnabled = context.extensionContext.globalState.get<boolean | undefined>(
-            CodeWhispererConstants.isClassifierEnabledKey
+    function determineUserGroup() {
+        const userGroup = context.extensionContext.globalState.get<CodeWhispererConstants.UserGroup | undefined>(
+            CodeWhispererConstants.userGroupKey
         )
-        if (isClassifierEnabled === undefined) {
-            const result = Math.random() <= 0.5
-            context.extensionContext.globalState.update(CodeWhispererConstants.isClassifierEnabledKey, result)
+        if (userGroup === undefined) {
+            const randomNum = Math.random()
+            const result =
+                randomNum <= 1 / 3
+                    ? CodeWhispererConstants.UserGroup.Control
+                    : randomNum <= 2 / 3
+                    ? CodeWhispererConstants.UserGroup.CrossFile
+                    : CodeWhispererConstants.UserGroup.Classifier
+
+            context.extensionContext.globalState.update(CodeWhispererConstants.userGroupKey, result)
         }
     }
 

src/codewhisperer/models/constants.ts

@@ -252,6 +252,12 @@ export const stopScanMessage =
 
 export const showScannedFilesMessage = 'Show Scanned Files'
 
-export const isClassifierEnabledKey = 'CODEWHISPERER_CLASSIFIER_TRIGGER_ENABLED'
+export const userGroupKey = 'CODEWHISPERER_USER_GROUP'
 
 export const updateInlineLockKey = 'CODEWHISPERER_INLINE_UPDATE_LOCK_KEY'
+
+export enum UserGroup {
+    Classifier = 'Classifier',
+    CrossFile = 'CrossFile',
+    Control = 'Control',
+}

src/codewhisperer/service/classifierTrigger.ts

@@ -319,7 +319,11 @@ export class ClassifierTrigger {
     }
 
     public isClassifierEnabled() {
-        return globals.context.globalState.get<boolean>(CodeWhispererConstants.isClassifierEnabledKey)
+        const userGroup = globals.context.globalState.get<CodeWhispererConstants.UserGroup | undefined>(
+            CodeWhispererConstants.userGroupKey
+        )
+
+        return userGroup === CodeWhispererConstants.UserGroup.Classifier
     }
 
     public getThreshold() {

src/codewhisperer/service/keyStrokeHandler.ts

@@ -126,10 +126,6 @@ export class KeyStrokeHandler {
                     triggerType = 'SpecialCharacters'
                     break
                 }
-                case DocumentChangedSource.IntelliSense: {
-                    triggerType = 'IntelliSenseAcceptance'
-                    break
-                }
                 case DocumentChangedSource.RegularKey: {
                     if (!ClassifierTrigger.instance.shouldInvokeClassifier(editor.document.languageId)) {
                         this.startIdleTimeTriggerTimer(event, editor, client, config)
@@ -303,10 +299,6 @@ export class DefaultDocumentChangedType extends DocumentChangedType {
             } else if (new RegExp('^[ ]+$').test(changedText)) {
                 // single line && single place reformat should consist of space chars only
                 return DocumentChangedSource.Reformatting
-            } else if (new RegExp('^[\\S]+$').test(changedText) && !isCloud9()) {
-                // match single word only, which is general case for intellisense suggestion, it's still possible intllisense suggest
-                // multi-words code snippets
-                return DocumentChangedSource.IntelliSense
             } else {
                 return isCloud9() ? DocumentChangedSource.RegularKey : DocumentChangedSource.Unknown
             }
@@ -322,7 +314,6 @@ export enum DocumentChangedSource {
     RegularKey = 'RegularKey',
     TabKey = 'TabKey',
     EnterKey = 'EnterKey',
-    IntelliSense = 'IntelliSense',
     Reformatting = 'Reformatting',
     Deletion = 'Deletion',
     Unknown = 'Unknown',

src/test/codewhisperer/service/keyStrokeHandler.test.ts

@@ -256,9 +256,6 @@ describe('keyStrokeHandler', function () {
             [':', DocumentChangedSource.SpecialCharsKey],
             ['a', DocumentChangedSource.RegularKey],
             [tabStr, DocumentChangedSource.TabKey],
-            ['__str__', DocumentChangedSource.IntelliSense],
-            ['toString()', DocumentChangedSource.IntelliSense],
-            ['</p>', DocumentChangedSource.IntelliSense],
             ['   ', DocumentChangedSource.Reformatting],
             ['def add(a,b):\n    return a + b\n', DocumentChangedSource.Unknown],
             ['function suggestedByIntelliSense():', DocumentChangedSource.Unknown],