feat: avoid throwing on missingFields

Author: Hweinstock

packages/core/src/shared/telemetry/util.ts

@@ -344,8 +344,9 @@ function validateMetadata(metricName: string, metadata: MetadataObj, fatal: bool
         logOrThrow(`"${metricName}" emitted with result=Failed but without the \`reason\` property.`, true)
     }
 
+    // TODO: there are many instances in the toolkit where we emit metrics with missing fields. If those can be removed, we can configure this to throw in CI.
     if (metadata.missingFields) {
-        logOrThrow(`"${metricName} emitted with missing fields: ${metadata.missingFields}`, false)
+        logger.warn(msgPrefix + `"${metricName} emitted with missing fields: ${metadata.missingFields}`, false)
     }
 }
 

packages/core/src/test/shared/telemetry/util.test.ts

@@ -376,7 +376,7 @@ describe('validateMetricEvent', function () {
         assertLogsContain('invalid Metric', false, 'warn')
     })
 
-    it('fails validation for metrics with missing fields when fatal=true', function () {
+    it('does not fail validation for metrics with missing fields when fatal=true', function () {
         const metricEvent: MetricDatum = {
             MetricName: 'invalid_metric_missing_fields',
             Value: 1,
@@ -387,7 +387,8 @@ describe('validateMetricEvent', function () {
             ],
         } as MetricDatum
 
-        assert.throws(() => validateMetricEvent(metricEvent, true), /emitted with missing fields/)
+        validateMetricEvent(metricEvent, false)
+        assertLogsContain('invalid Metric', false, 'warn')
     })
 
     it('logs warning for metrics with missing fields when fatal=false', function () {