adjust flag, add techdebt test

Author: Hweinstock

.github/workflows/node.js.yml

@@ -44,7 +44,7 @@ jobs:
                 node-version: [16.x]
                 vscode-version: [stable]
         env:
-            NODE_OPTIONS: '--max-old-space-size=8192 --experimental-filesystem'
+            NODE_OPTIONS: '--max-old-space-size=8192 --experimental-fs'
         steps:
             - uses: actions/checkout@v4
             - name: Use Node.js ${{ matrix.node-version }}
@@ -66,7 +66,7 @@ jobs:
                 vscode-version: [minimum, stable, insiders]
         env:
             VSCODE_TEST_VERSION: ${{ matrix.vscode-version }}
-            NODE_OPTIONS: '--max-old-space-size=8192 --experimental-filesystem'
+            NODE_OPTIONS: '--max-old-space-size=8192 --experimental-fs'
             AWS_TOOLKIT_TEST_CACHE_DIR: '/tmp/.vscode-test/'
             AWS_TOOLKIT_TEST_USER_DIR: '/tmp/.vscode-test/user-data/'
         steps:
@@ -136,7 +136,7 @@ jobs:
                 vscode-version: [stable, insiders]
         env:
             VSCODE_TEST_VERSION: ${{ matrix.vscode-version }}
-            NODE_OPTIONS: '--max-old-space-size=8192 --experimental-filesystem'
+            NODE_OPTIONS: '--max-old-space-size=8192 --experimental-fs'
             AWS_TOOLKIT_TEST_CACHE_DIR: '/tmp/.vscode-test/'
             AWS_TOOLKIT_TEST_USER_DIR: '/tmp/.vscode-test/user-data/'
         steps:
@@ -162,7 +162,7 @@ jobs:
                 vscode-version: [stable, insiders]
         env:
             VSCODE_TEST_VERSION: ${{ matrix.vscode-version }}
-            NODE_OPTIONS: '--max-old-space-size=8192 --experimental-filesystem'
+            NODE_OPTIONS: '--max-old-space-size=8192 --experimental-fs'
         steps:
             - uses: actions/checkout@v4
             - name: Use Node.js ${{ matrix.node-version }}

.github/workflows/release.yml

@@ -20,7 +20,7 @@ jobs:
     package:
         runs-on: ubuntu-latest
         env:
-            NODE_OPTIONS: '--max-old-space-size=8192 --experimental-filesystem'
+            NODE_OPTIONS: '--max-old-space-size=8192 --experimental-fs'
         outputs:
             feature: ${{ steps.build.outputs.feature }}
             tagname: ${{ steps.build.outputs.tagname }}

buildspec/packageTestVsix.yml

@@ -7,7 +7,7 @@ env:
     variables:
         AWS_TOOLKIT_TEST_USER_DIR: '/tmp/'
         # needed or else webpack will cause it to run out of memory
-        NODE_OPTIONS: '--max-old-space-size=8192 --experimental-filesystem'
+        NODE_OPTIONS: '--max-old-space-size=8192 --experimental-fs'
 
 phases:
     install:

buildspec/release/00clonerepo.yml

@@ -2,7 +2,7 @@ version: 0.2
 
 env:
     variables:
-        NODE_OPTIONS: '--max-old-space-size=8192 --experimental-filesystem'
+        NODE_OPTIONS: '--max-old-space-size=8192 --experimental-fs'
 
 phases:
     install:

buildspec/release/10changeversion.yml

@@ -2,7 +2,7 @@ version: 0.2
 
 env:
     variables:
-        NODE_OPTIONS: '--max-old-space-size=8192 --experimental-filesystem'
+        NODE_OPTIONS: '--max-old-space-size=8192 --experimental-fs'
 
 phases:
     pre_build:

buildspec/release/20buildrelease.yml

@@ -2,7 +2,7 @@ version: 0.2
 
 env:
     variables:
-        NODE_OPTIONS: '--max-old-space-size=8192 --experimental-filesystem'
+        NODE_OPTIONS: '--max-old-space-size=8192 --experimental-fs'
 
 phases:
     pre_build:

buildspec/release/40pushtogithub.yml

@@ -2,7 +2,7 @@ version: 0.2
 
 env:
     variables:
-        NODE_OPTIONS: '--max-old-space-size=8192 --experimental-filesystem'
+        NODE_OPTIONS: '--max-old-space-size=8192 --experimental-fs'
 
 phases:
     install:

buildspec/shared/linux-pre_build.sh

@@ -22,5 +22,5 @@ if [ "$TOOLKITS_CODEARTIFACT_DOMAIN" ] && [ "$TOOLKITS_CODEARTIFACT_REPO" ] && [
 fi
 
 # TODO: move this to the "install" phase?
-export NODE_OPTIONS=--max-old-space-size=8192 --experimental-filesystem
+export NODE_OPTIONS=--max-old-space-size=8192 --experimental-fs
 npm 2>&1 ci | run_and_report 2 'npm WARN deprecated' 'Deprecated dependencies must be updated.'

packages/core/src/test/techdebt.test.ts

@@ -46,4 +46,10 @@ describe('tech debt', function () {
         // auth_modifyConnection.action = deleteProfile OR auth_modifyConnection.source contains CodeCatalyst
         fixByDate('2024-10-30', 'Remove the edge case code from the commit that this test is a part of.')
     })
+
+    it('remove node flag for experimental', async function () {
+        const minNodejs = env.getMinNodejsVersion()
+
+        assert.ok(semver.lt(minNodejs, '22.3.0'), 'with node 22.3.0+ we no longer need the --experimental-fs flag')
+    })
 })