Skip to content

Commit 1b9bf64

Browse files
committed
remove getUserGroup usage
1 parent 834dd09 commit 1b9bf64

File tree

7 files changed

+9
-33
lines changed

7 files changed

+9
-33
lines changed

package-lock.json

Lines changed: 5 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939
"generateNonCodeFiles": "npm run generateNonCodeFiles -w packages/ --if-present"
4040
},
4141
"devDependencies": {
42-
"@aws-toolkits/telemetry": "^1.0.258",
42+
"@aws-toolkits/telemetry": "^1.0.259",
4343
"@playwright/browser-chromium": "^1.43.1",
4444
"@types/vscode": "^1.68.0",
4545
"@types/vscode-webview": "^1.57.1",

packages/core/src/codewhisperer/service/recommendationHandler.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ import globals from '../../shared/extensionGlobals'
3838
import { noSuggestions, updateInlineLockKey } from '../models/constants'
3939
import AsyncLock from 'async-lock'
4040
import { AuthUtil } from '../util/authUtil'
41-
import { CodeWhispererUserGroupSettings } from '../util/userGroupUtil'
4241
import { CWInlineCompletionItemProvider } from './inlineCompletionItemProvider'
4342
import { application } from '../util/codeWhispererApplication'
4443
import { openUrl } from '../../shared/utilities/vsCodeUtils'
@@ -698,7 +697,6 @@ export class RecommendationHandler {
698697
duration: performance.now() - this.lastInvocationTime,
699698
passive: true,
700699
credentialStartUrl: AuthUtil.instance.startUrl,
701-
codewhispererUserGroup: CodeWhispererUserGroupSettings.getUserGroup().toString(),
702700
result: 'Succeeded',
703701
})
704702
}

packages/core/src/codewhisperer/tracker/codewhispererCodeCoverageTracker.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ import { CodewhispererLanguage, telemetry } from '../../shared/telemetry/telemet
1313
import { runtimeLanguageContext } from '../util/runtimeLanguageContext'
1414
import { TelemetryHelper } from '../util/telemetryHelper'
1515
import { AuthUtil } from '../util/authUtil'
16-
import { CodeWhispererUserGroupSettings } from '../util/userGroupUtil'
1716
import { getSelectedCustomization } from '../util/customizationUtil'
1817
import { codeWhispererClient as client } from '../client/codewhisperer'
1918
import { isAwsError } from '../../shared/errors'
@@ -134,7 +133,6 @@ export class CodeWhispererCodeCoverageTracker {
134133
codewhispererSuggestedTokens: acceptedTokens,
135134
codewhispererPercentage: percentage ? percentage : 0,
136135
successCount: this._serviceInvocationCount,
137-
codewhispererUserGroup: CodeWhispererUserGroupSettings.getUserGroup().toString(),
138136
codewhispererCustomizationArn: selectedCustomization.arn === '' ? undefined : selectedCustomization.arn,
139137
credentialStartUrl: AuthUtil.instance.startUrl,
140138
})

packages/core/src/codewhisperer/tracker/codewhispererTracker.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ import { distance } from 'fastest-levenshtein'
99
import { AcceptedSuggestionEntry } from '../models/model'
1010
import { getLogger } from '../../shared/logger/logger'
1111
import { AmazonqModifyCode, telemetry } from '../../shared/telemetry/telemetry'
12-
import { CodeWhispererUserGroupSettings } from '../util/userGroupUtil'
1312
import { AuthUtil } from '../util/authUtil'
1413
import { InsertedCode } from '../../codewhispererChat/controllers/chat/model'
1514
import { codeWhispererClient } from '../client/codewhisperer'
@@ -137,7 +136,6 @@ export class CodeWhispererTracker {
137136
codewhispererCompletionType: suggestion.completionType,
138137
codewhispererLanguage: suggestion.language,
139138
credentialStartUrl: AuthUtil.instance.startUrl,
140-
codewhispererUserGroup: CodeWhispererUserGroupSettings.getUserGroup().toString(),
141139
codewhispererCharactersAccepted: suggestion.originalString.length,
142140
codewhispererCharactersModified: 0, // TODO: currently we don't have an accurate number for this field with existing implementation
143141
})

packages/core/src/codewhisperer/util/supplementalContext/utgUtils.ts

Lines changed: 3 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,6 @@ import { ToolkitError } from '../../../shared/errors'
1818
import { supplemetalContextFetchingTimeoutMsg } from '../../models/constants'
1919
import { CancellationError } from '../../../shared/utilities/timeoutUtils'
2020
import { utgConfig } from '../../models/constants'
21-
import { CodeWhispererUserGroupSettings } from '../userGroupUtil'
22-
import { UserGroup } from '../../models/constants'
2321
import { getOpenFilesInWindow } from '../../../shared/utilities/editorUtilities'
2422
import { getLogger } from '../../../shared/logger/logger'
2523
import { CodeWhispererSupplementalContext, CodeWhispererSupplementalContextItem, UtgStrategy } from '../../models/model'
@@ -30,19 +28,12 @@ function isUtgSupportedLanguage(languageId: vscode.TextDocument['languageId']):
3028
return languageId in utgLanguageConfigs
3129
}
3230

33-
export function shouldFetchUtgContext(
34-
languageId: vscode.TextDocument['languageId'],
35-
userGroup: UserGroup
36-
): boolean | undefined {
31+
export function shouldFetchUtgContext(languageId: vscode.TextDocument['languageId']): boolean | undefined {
3732
if (!isUtgSupportedLanguage(languageId)) {
3833
return undefined
3934
}
4035

41-
if (languageId === 'java') {
42-
return true
43-
} else {
44-
return userGroup === UserGroup.CrossFile
45-
}
36+
return languageId === 'java'
4637
}
4738

4839
/**
@@ -58,10 +49,7 @@ export async function fetchSupplementalContextForTest(
5849
editor: vscode.TextEditor,
5950
cancellationToken: vscode.CancellationToken
6051
): Promise<Pick<CodeWhispererSupplementalContext, 'supplementalContextItems' | 'strategy'> | undefined> {
61-
const shouldProceed = shouldFetchUtgContext(
62-
editor.document.languageId,
63-
CodeWhispererUserGroupSettings.instance.userGroup
64-
)
52+
const shouldProceed = shouldFetchUtgContext(editor.document.languageId)
6553

6654
if (!shouldProceed) {
6755
return shouldProceed === undefined ? undefined : { supplementalContextItems: [], strategy: 'Empty' }

packages/core/src/codewhisperer/util/telemetryHelper.ts

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ import {
1818
import { CodewhispererCompletionType, CodewhispererSuggestionState } from '../../shared/telemetry/telemetry'
1919
import { getImportCount } from './importAdderUtil'
2020
import { CodeWhispererSettings } from './codewhispererSettings'
21-
import { CodeWhispererUserGroupSettings } from './userGroupUtil'
2221
import { getSelectedCustomization } from './customizationUtil'
2322
import { AuthUtil } from './authUtil'
2423
import { isAwsError } from '../../shared/errors'
@@ -88,7 +87,6 @@ export class TelemetryHelper {
8887
codewhispererSupplementalContextIsUtg: supplementalContextMetadata?.isUtg,
8988
codewhispererSupplementalContextLatency: supplementalContextMetadata?.latency,
9089
codewhispererSupplementalContextLength: supplementalContextMetadata?.contentsLength,
91-
codewhispererUserGroup: CodeWhispererUserGroupSettings.getUserGroup().toString(),
9290
codewhispererCustomizationArn: getSelectedCustomization().arn,
9391
}
9492
telemetry.codewhisperer_serviceInvocation.emit(event)
@@ -114,7 +112,6 @@ export class TelemetryHelper {
114112
codewhispererLanguage: language,
115113
codewhispererGettingStartedTask: session.taskType,
116114
credentialStartUrl: AuthUtil.instance.startUrl,
117-
codewhispererUserGroup: CodeWhispererUserGroupSettings.getUserGroup().toString(),
118115
codewhispererSupplementalContextTimeout: supplementalContextMetadata?.isProcessTimeout,
119116
codewhispererSupplementalContextIsUtg: supplementalContextMetadata?.isUtg,
120117
codewhispererSupplementalContextLength: supplementalContextMetadata?.contentsLength,
@@ -167,7 +164,6 @@ export class TelemetryHelper {
167164
codewhispererLanguage: session.language,
168165
codewhispererGettingStartedTask: session.taskType,
169166
credentialStartUrl: AuthUtil.instance.startUrl,
170-
codewhispererUserGroup: CodeWhispererUserGroupSettings.getUserGroup().toString(),
171167
codewhispererSupplementalContextTimeout: supplementalContextMetadata?.isProcessTimeout,
172168
codewhispererSupplementalContextIsUtg: supplementalContextMetadata?.isUtg,
173169
codewhispererSupplementalContextLength: supplementalContextMetadata?.contentsLength,
@@ -230,7 +226,6 @@ export class TelemetryHelper {
230226
.map((e) => e.codewhispererSuggestionImportCount || 0)
231227
.reduce((a, b) => a + b, 0),
232228
codewhispererTypeaheadLength: 0,
233-
codewhispererUserGroup: CodeWhispererUserGroupSettings.getUserGroup().toString(),
234229
codewhispererSupplementalContextTimeout: supplementalContextMetadata?.isProcessTimeout,
235230
codewhispererSupplementalContextIsUtg: supplementalContextMetadata?.isUtg,
236231
codewhispererSupplementalContextLength: supplementalContextMetadata?.contentsLength,
@@ -290,7 +285,6 @@ export class TelemetryHelper {
290285
codewhispererPreviousSuggestionState: this.prevTriggerDecision,
291286
codewhispererClassifierResult: this.classifierResult,
292287
codewhispererClassifierThreshold: this.classifierThreshold,
293-
codewhispererUserGroup: CodeWhispererUserGroupSettings.getUserGroup().toString(),
294288
codewhispererSupplementalContextTimeout: supplementalContextMetadata?.isProcessTimeout,
295289
codewhispererSupplementalContextIsUtg: supplementalContextMetadata?.isUtg,
296290
codewhispererSupplementalContextLength: supplementalContextMetadata?.contentsLength,
@@ -528,7 +522,6 @@ export class TelemetryHelper {
528522
codewhispererTriggerType: session.triggerType,
529523
codewhispererLanguage: session.language,
530524
credentialStartUrl: AuthUtil.instance.startUrl,
531-
codewhispererUserGroup: CodeWhispererUserGroupSettings.getUserGroup().toString(),
532525
codewhispererCustomizationArn: getSelectedCustomization().arn,
533526
})
534527
}

0 commit comments

Comments
 (0)