del: remove batched iterator

Author: Hweinstock

packages/core/src/shared/utilities/asyncCollection.ts

@@ -61,11 +61,6 @@ export interface AsyncCollection<T> extends AsyncIterable<T> {
      * Returns an iterator directly from the underlying generator, preserving values returned.
      */
     iterator(): AsyncIterator<T, T | void>
-
-    /**
-     * Returns a batched iterator of any size directly from the underlying generator, preserving values returned.
-     */
-    batchedIterator(batchSize: number): AsyncIterator<T[], void | T[]>
 }
 
 const asyncCollection = Symbol('asyncCollection')
@@ -108,38 +103,9 @@ export function toCollection<T>(generator: () => AsyncGenerator<T, T | undefined
         toMap: <U extends string = never, K extends StringProperty<T> = never>(selector: KeySelector<T, U> | K) =>
             asyncIterableToMap(iterable, selector),
         iterator: generator,
-        batchedIterator: (batchSize: number) => batchIterator(batchSize, filterGenerator(generator(), Boolean)),
     })
 }
 
-/**
- * Transform an iterator to return batches of size 'batchSize'.
- * @param batchSize
- * @param iterator
- */
-export async function* batchIterator<T>(
-    batchSize: number,
-    iterator: AsyncIterator<T, void | T>
-): AsyncIterator<T[], void | T[]> {
-    let batch: T[] = []
-    let nextResult = await iterator.next()
-
-    while (!nextResult.done) {
-        batch.push(nextResult.value)
-
-        if (batch.length === batchSize) {
-            yield batch
-            batch = []
-        }
-
-        nextResult = await iterator.next()
-    }
-
-    if (batch.length > 0) {
-        yield batch
-    }
-}
-
 export function isAsyncCollection<T>(iterable: AsyncIterable<T>): iterable is AsyncCollection<T> {
     return asyncCollection in iterable
 }

packages/core/src/test/shared/utilities/asyncCollection.test.ts

@@ -5,7 +5,6 @@
 
 import assert from 'assert'
 import { toCollection } from '../../../shared/utilities/asyncCollection'
-import { intoCollection } from '../../../shared/utilities/collectionUtils'
 
 describe('AsyncCollection', function () {
     const items = [
@@ -206,35 +205,6 @@ describe('AsyncCollection', function () {
         assert.strictEqual(counter.callCount, 7)
     })
 
-    describe('batchedIterator', function () {
-        const items = [1, 2, 3, 4, 5, 6, 7, 8, 9]
-        const mixedItems = [1, '2', 3, '4', 5, '6']
-
-        it('can iterator batches at a time', async function () {
-            const batchedIterator = intoCollection(items).batchedIterator(3)
-            assert.deepStrictEqual((await batchedIterator.next()).value, [1, 2, 3], 'first batch')
-            assert.deepStrictEqual((await batchedIterator.next()).value, [4, 5, 6], 'second batch')
-            assert.deepStrictEqual((await batchedIterator.next()).value, [7, 8, 9], 'third batch')
-            assert.ok((await batchedIterator.next()).done)
-        })
-
-        it('can handle partial batches', async function () {
-            const batchedIterator = intoCollection(items).batchedIterator(4)
-            assert.deepStrictEqual((await batchedIterator.next()).value, [1, 2, 3, 4], 'first batch')
-            assert.deepStrictEqual((await batchedIterator.next()).value, [5, 6, 7, 8], 'second batch')
-            assert.deepStrictEqual((await batchedIterator.next()).value, [9], 'third batch')
-            assert.ok((await batchedIterator.next()).done)
-        })
-
-        it('can handle mixed valued batches', async function () {
-            const batchedIterator = intoCollection(mixedItems).batchedIterator(2)
-            assert.deepStrictEqual((await batchedIterator.next()).value, [1, '2'], 'first batch')
-            assert.deepStrictEqual((await batchedIterator.next()).value, [3, '4'], 'second batch')
-            assert.deepStrictEqual((await batchedIterator.next()).value, [5, '6'], 'third batch')
-            assert.ok((await batchedIterator.next()).done)
-        })
-    })
-
     describe('errors', function () {
         async function* error() {
             throw new Error()