feat(amazonq): sync telemetry client id between extensions (#4698)

Alternative to: #4683

## Problem

The elemetry client id has to to be the same between Amazon Q and AWS Toolkit

## Solution

VS Code extensions are in same process. Use `process.env` to pass the telemetry client id. Each extension attempt to set its telemetry client id at time of activation. 

There can be edge cases when Q activates but toolkit is uninstalled (still has old client id), in this case, the 2nd time vscode window reloads, the amazon Q will sync its client id with AWS toolkit. 

commits:

* ws space

* use process.env

* update debug log

* rerun-test

* move setup client id to utils

* Update packages/core/src/shared/telemetry/activation.ts

* fix conflict

---------

Co-authored-by: Justin M. Keyes <[email protected]>

Author: leigaol

packages/core/src/shared/telemetry/activation.ts

@@ -14,7 +14,7 @@ import { DefaultTelemetryService } from './telemetryService'
 import { getLogger } from '../logger'
 import { getComputeRegion, getIdeProperties, isCloud9 } from '../extensionUtilities'
 import { openSettings, Settings } from '../settings'
-import { TelemetryConfig } from './util'
+import { TelemetryConfig, setupTelemetryId } from './util'
 import { isAutomation, isReleaseVersion } from '../vscode/env'
 
 export const noticeResponseViewSettings = localize('AWS.telemetry.notificationViewSettings', 'Settings')
@@ -52,7 +52,7 @@ export async function activate(extensionContext: vscode.ExtensionContext, awsCon
         if (!isCloud9() && !hasUserSeenTelemetryNotice(extensionContext)) {
             showTelemetryNotice(extensionContext)
         }
-
+        await setupTelemetryId(extensionContext)
         await globals.telemetry.start()
     } catch (e) {
         // Only throw in a production build because:

packages/core/src/shared/telemetry/util.ts

@@ -3,6 +3,7 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
+import * as vscode from 'vscode'
 import { env, Memento, version } from 'vscode'
 import { getLogger } from '../logger'
 import { fromExtensionManifest } from '../settings'
@@ -17,11 +18,14 @@ import { MetricDatum } from './clienttelemetry'
 import { isValidationExemptMetric } from './exemptMetrics'
 import { isCloud9, isSageMaker } from '../../shared/extensionUtilities'
 import { VSCODE_EXTENSION_ID } from '../utilities'
+import { isWeb } from '../../common/webUtils'
 
 const legacySettingsTelemetryValueDisable = 'Disable'
 const legacySettingsTelemetryValueEnable = 'Enable'
 
 const TelemetryFlag = addTypeName('boolean', convertLegacy)
+const telemetryClientIdGlobalStatekey = 'telemetryClientId'
+const telemetryClientIdEnvKey = '__TELEMETRY_CLIENT_ID'
 
 export class TelemetryConfig extends fromExtensionManifest('aws', { telemetry: TelemetryFlag }) {
     public isEnabled(): boolean {
@@ -53,10 +57,10 @@ export const getClientId = shared(
             return '11111111-1111-1111-1111-111111111111'
         }
         try {
-            let clientId = globalState.get<string>('telemetryClientId')
+            let clientId = globalState.get<string>(telemetryClientIdGlobalStatekey)
             if (!clientId) {
                 clientId = randomUUID()
-                await globalState.update('telemetryClientId', clientId)
+                await globalState.update(telemetryClientIdGlobalStatekey, clientId)
             }
             return clientId
         } catch (error) {
@@ -158,3 +162,44 @@ export function validateMetricEvent(event: MetricDatum, fatal: boolean) {
         getLogger().warn(msg)
     }
 }
+
+/**
+ * Setup the telemetry client id at extension activation.
+ * This function is designed to let AWS Toolkit and Amazon Q share
+ * the same telemetry client id.
+ */
+
+export async function setupTelemetryId(extensionContext: vscode.ExtensionContext) {
+    try {
+        if (isWeb()) {
+            await globals.context.globalState.update(telemetryClientIdGlobalStatekey, vscode.env.machineId)
+        } else {
+            const currentClientId = globals.context.globalState.get<string>(telemetryClientIdGlobalStatekey)
+            const storedClientId = process.env[telemetryClientIdEnvKey]
+            if (currentClientId && storedClientId) {
+                if (extensionContext.extension.id === VSCODE_EXTENSION_ID.awstoolkit) {
+                    getLogger().debug(`telemetry: Store telemetry client id to env ${currentClientId}`)
+                    process.env[telemetryClientIdEnvKey] = currentClientId
+                } else if (extensionContext.extension.id === VSCODE_EXTENSION_ID.amazonq) {
+                    getLogger().debug(`telemetry: Set telemetry client id to ${currentClientId}`)
+                    await globals.context.globalState.update(telemetryClientIdGlobalStatekey, currentClientId)
+                } else {
+                    getLogger().error(`Unexpected extension id ${extensionContext.extension.id}`)
+                }
+            } else if (!currentClientId && storedClientId) {
+                getLogger().debug(`telemetry: Write telemetry client id to global state ${storedClientId}`)
+                await globals.context.globalState.update(telemetryClientIdGlobalStatekey, storedClientId)
+            } else if (currentClientId && !storedClientId) {
+                getLogger().debug(`telemetry: Write telemetry client id to env ${currentClientId}`)
+                process.env[telemetryClientIdEnvKey] = currentClientId
+            } else {
+                const clientId = randomUUID()
+                getLogger().debug(`telemetry: Setup telemetry client id ${clientId}`)
+                await globals.context.globalState.update(telemetryClientIdGlobalStatekey, clientId)
+                process.env[telemetryClientIdEnvKey] = clientId
+            }
+        }
+    } catch (err) {
+        getLogger().error(`Erro while setting up telemetry id ${err}`)
+    }
+}