fix: circular dependencies

Author: avi-alpert

packages/core/src/codewhispererChat/constants.ts

@@ -0,0 +1,21 @@
+/*!
+ * Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+ * SPDX-License-Identifier: Apache-2.0
+ */
+import * as path from 'path'
+import fs from '../shared/fs/fs'
+
+export const promptFileExtension = '.md'
+
+export const additionalContentInnerContextLimit = 8192
+
+export const aditionalContentNameLimit = 1024
+
+// temporary limit for @workspace and @file combined context length
+export const contextMaxLength = 40_000
+
+export const getUserPromptsDirectory = () => {
+    return path.join(fs.getUserHomeDir(), '.aws', 'amazonq', 'prompts')
+}
+
+export const createSavedPromptCommandId = 'create-saved-prompt'

packages/core/src/codewhispererChat/controllers/chat/controller.ts

@@ -71,6 +71,14 @@ import { workspaceCommand } from '../../../amazonq/webview/ui/tabs/constants'
 import fs from '../../../shared/fs/fs'
 import { FeatureConfigProvider, Features } from '../../../shared/featureConfig'
 import { i18n } from '../../../shared/i18n-helper'
+import {
+    getUserPromptsDirectory,
+    promptFileExtension,
+    createSavedPromptCommandId,
+    aditionalContentNameLimit,
+    additionalContentInnerContextLimit,
+    contextMaxLength,
+} from '../../constants'
 
 export interface ChatControllerMessagePublishers {
     readonly processPromptChatMessage: MessagePublisher<PromptMessage>
@@ -122,21 +130,6 @@ export interface ChatControllerMessageListeners {
     readonly processFileClick: MessageListener<FileClick>
 }
 
-const promptFileExtension = '.md'
-
-const additionalContentInnerContextLimit = 8192
-
-const aditionalContentNameLimit = 1024
-
-// temporary limit for @workspace and @file combined context length
-const contextMaxLength = 40_000
-
-export const getUserPromptsDirectory = () => {
-    return path.join(fs.getUserHomeDir(), '.aws', 'amazonq', 'prompts')
-}
-
-const createSavedPromptCommandId = 'create-saved-prompt'
-
 export class ChatController {
     private readonly sessionStorage: ChatSessionStorage
     private readonly triggerEventsStorage: TriggerEventsStorage

packages/core/src/codewhispererChat/controllers/chat/telemetryHelper.ts

@@ -40,7 +40,7 @@ import { AuthUtil } from '../../../codewhisperer/util/authUtil'
 import { getSelectedCustomization } from '../../../codewhisperer/util/customizationUtil'
 import { undefinedIfEmpty } from '../../../shared/utilities/textUtilities'
 import { AdditionalContextPrompt } from '../../../amazonq/lsp/types'
-import { getUserPromptsDirectory } from './controller'
+import { getUserPromptsDirectory } from '../../constants'
 
 export function logSendTelemetryEventFailure(error: any) {
     let requestId: string | undefined