Addressing comments

Author: laileni-aws

packages/core/src/codewhispererChat/clients/chat/v0/chat.ts

@@ -13,6 +13,11 @@ import { UserWrittenCodeTracker } from '../../../../codewhisperer/tracker/userWr
 
 export class ChatSession {
     private sessionId?: string
+    /**
+     * _listOfReadFiles = list of files read from the project to gather context before generating response.
+     * _filePath = The path helps the system locate exactly where to make the necessary changes in the project structure
+     * _tempFilePath = Used to show the code diff view in the editor including LLM changes.
+     */
     private _listOfReadFiles: string[] = []
     private _filePath: string | undefined
     private _tempFilePath: string | undefined
@@ -41,10 +46,10 @@ export class ChatSession {
     public get listOfReadFiles(): string[] {
         return this._listOfReadFiles
     }
-    public get getFilePath(): string | undefined {
+    public get filePath(): string | undefined {
         return this._filePath
     }
-    public get getTempFilePath(): string | undefined {
+    public get tempFilePath(): string | undefined {
         return this._tempFilePath
     }
     public setFilePath(filePath: string | undefined) {
@@ -53,12 +58,11 @@ export class ChatSession {
     public setTempFilePath(tempFilePath: string | undefined) {
         this._tempFilePath = tempFilePath
     }
-    public pushToListOfReadFiles(filePath?: string) {
-        if (filePath) {
-            this._listOfReadFiles.push(filePath)
-        } else {
-            this._listOfReadFiles = []
-        }
+    public pushToListOfReadFiles(filePath: string) {
+        this._listOfReadFiles.push(filePath)
+    }
+    public clearListOfReadFiles() {
+        this._listOfReadFiles = []
     }
     async chatIam(chatRequest: SendMessageRequest): Promise<SendMessageCommandOutput> {
         const client = await createQDeveloperStreamingClient()

packages/core/src/codewhispererChat/controllers/chat/controller.ts

@@ -398,23 +398,23 @@ export class ChatController {
 
     private async processOpenDiff(message: OpenDiff) {
         const session = this.sessionStorage.getSession(message.tabID)
-        const filePath = session.getFilePath ?? message.filePath
+        const filePath = session.filePath ?? message.filePath
         const fileExists = await fs.existsFile(filePath)
         // Check if fileExists=false, If yes, return instead of showing broken diff experience.
-        if (!session.getTempFilePath) {
+        if (!session.tempFilePath) {
             return
         }
         const leftUri = fileExists ? vscode.Uri.file(filePath) : vscode.Uri.from({ scheme: 'untitled' })
-        const rightUri = vscode.Uri.file(session.getTempFilePath ?? filePath)
+        const rightUri = vscode.Uri.file(session.tempFilePath ?? filePath)
         const fileName = path.basename(filePath)
         await vscode.commands.executeCommand('vscode.diff', leftUri, rightUri, `${fileName} ${amazonQTabSuffix}`)
     }
 
     private async processAcceptCodeDiff(message: CustomFormActionMessage) {
         const session = this.sessionStorage.getSession(message.tabID ?? '')
-        const filePath = session.getFilePath ?? ''
+        const filePath = session.filePath ?? ''
         const fileExists = await fs.existsFile(filePath)
-        const tempFilePath = session.getTempFilePath
+        const tempFilePath = session.tempFilePath
         const tempFileExists = await fs.existsFile(tempFilePath ?? '')
         if (fileExists && tempFileExists) {
             const fileContent = await fs.readFileText(filePath)
@@ -889,7 +889,7 @@ export class ChatController {
 
     private async processPromptMessageAsNewThread(message: PromptMessage) {
         const session = this.sessionStorage.getSession(message.tabID)
-        session.pushToListOfReadFiles(undefined)
+        session.clearListOfReadFiles()
         this.editorContextExtractor
             .extractContextForTrigger('ChatMessage')
             .then((context) => {