addressed comments

Author: tomcat323

packages/amazonq/test/e2e/inline/inline.test.ts

@@ -24,7 +24,7 @@ describe('Amazon Q Inline', async function () {
     const waitOptions = {
         interval: 500,
         timeout: 10000,
-        retryOnFail: () => true,
+        retryOnFail: () => false,
     }
 
     before(async function () {

packages/core/src/shared/resourcefetcher/httpResourceFetcher.ts

@@ -120,8 +120,8 @@ export class HttpResourceFetcher implements ResourceFetcher<Response> {
                 timeout: 3000,
                 interval: 100,
                 backoff: 2,
-                retryOnFail: (error: Error | undefined) => {
-                    // Only stops retry when the user intentionally canceled the operation.
+                retryOnFail: (error?: Error) => {
+                    // Retry unless the user intentionally canceled the operation.
                     return error ? !isUserCancelledError(error) : true
                 },
             }

packages/core/src/shared/utilities/timeoutUtils.ts

@@ -222,14 +222,16 @@ interface WaitUntilOptions {
     /** A backoff multiplier for how long the next interval will be (default: None, i.e 1) */
     readonly backoff?: number
     /**
-     * Call back, true when the function should be retried on failure.
+     * Callback, returns `true` when the function should be retried on failure.
+     *
      * Example usage:
-     * - () => boolean if the retry logic is "constant"
-     * - (error) => { error ? retryOnError(error) : boolean }
-     *   where retryOnError determines what errors to retry, and the boolean is for base case when there's no error (undefined)
-     * 'truthy' arg is ignored
-     * If the timeout is reached it throws the last error
-     * Default to false
+     * - `() => boolean` if the retry logic is "constant".
+     * - `(error) => { error ? retryOnError(error) : boolean }`
+     *   where `retryOnError` determines what errors to retry, and the boolean is for the base case when there's no error (undefined).
+     *
+     * The `truthy` argument is ignored.
+     * If the timeout is reached, it throws the last error.
+     * Defaults to `false`.
      */
     readonly retryOnFail?: (error: Error | undefined) => boolean
 }
@@ -248,7 +250,7 @@ export const waitUntilDefaultInterval = 500
  */
 export async function waitUntil<T>(
     fn: () => Promise<T>,
-    options: WaitUntilOptions & { retryOnFail: (error: Error | undefined) => boolean }
+    options: WaitUntilOptions & { retryOnFail: (error?: Error) => boolean }
 ): Promise<T>
 
 export async function waitUntil<T>(

packages/core/src/test/shared/utilities/timeoutUtils.test.ts

@@ -401,7 +401,7 @@ export const timeoutUtilsDescribe = describe('timeoutUtils', async function () {
 
             const res = waitUntil(fn, {
                 retryOnFail: (error) => {
-                    return error ? error.message === 'Retry error' : false
+                    return error?.message === 'Retry error'
                 },
             })
 
@@ -421,7 +421,7 @@ export const timeoutUtilsDescribe = describe('timeoutUtils', async function () {
             const res = assert.rejects(
                 waitUntil(fn, {
                     retryOnFail: (error) => {
-                        return error ? error.message === 'Retry error' : true
+                        return error?.message === 'Retry error'
                     },
                 }),
                 (e) => e instanceof Error && e.message === 'Last error'