Skip to content

Commit 2564ee6

Browse files
author
tomzu
committed
adressed comments
1 parent e90c9c0 commit 2564ee6

File tree

2 files changed

+13
-12
lines changed

2 files changed

+13
-12
lines changed

packages/core/src/dev/activation.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -454,7 +454,7 @@ const resettableFeatures: readonly ResettableFeature[] = [
454454
},
455455
{
456456
name: 'workspace lsp',
457-
label: 'Lsp Download',
457+
label: 'Download Lsp ',
458458
detail: 'Resets workspace LSP',
459459
executor: resetWorkspaceLspDownload,
460460
},

packages/core/src/shared/lsp/manifestResolver.ts

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -108,21 +108,22 @@ export class ManifestResolver {
108108
* Check if the current manifest is deprecated.
109109
* If yes and user hasn't muted this notification, shows a toast message with two buttons:
110110
* - OK: close and do nothing
111-
* - Don't Show Again: Update global state (muteDecprecation) so the deprecation message is never shown for this manifest.
111+
* - Don't Show Again: Update global state (muteDeprecation) so the deprecation message is never shown for this manifest.
112112
* @param manifest
113113
*/
114114
private checkDeprecation(manifest: Manifest): void {
115-
if (manifest.isManifestDeprecated && !this.getStorage()[this.lsName].muteDeprecation) {
116-
const deprecationMessage = `${this.lsName} manifest is deprecated. No future updates will be available.`
115+
const deprecationMessage = `${this.lsName} manifest is deprecated. No future updates will be available.`
116+
if (manifest.isManifestDeprecated) {
117117
logger.info(deprecationMessage)
118-
119-
void vscode.window
120-
.showInformationMessage(deprecationMessage, localizedText.ok, localizedText.dontShow)
121-
.then((button) => {
122-
if (button === localizedText.dontShow) {
123-
this.getStorage()[this.lsName].muteDeprecation = true
124-
}
125-
})
118+
if (!this.getStorage()[this.lsName].muteDeprecation) {
119+
void vscode.window
120+
.showInformationMessage(deprecationMessage, localizedText.ok, localizedText.dontShow)
121+
.then((button) => {
122+
if (button === localizedText.dontShow) {
123+
this.getStorage()[this.lsName].muteDeprecation = true
124+
}
125+
})
126+
}
126127
}
127128
}
128129

0 commit comments

Comments
 (0)