Updates version of asl service, allows users to replace arn values with placeholders (#1103)

New version of asl service relaxes requirement for Resource property of task state. It will accept any string now. Removed filter removing arn errors for visualisation validation as it is no longer necessary.
From now, any additional properties that are not in ASL specification will be marked as invalid.

Authored-by: Alan Bogusiewicz <[email protected]>

Author: alanbo

.changes/next-release/Feature-e5a8005f-e76b-4b99-a69f-62b72725d00e.json

@@ -0,0 +1,4 @@
+{
+    "type": "Feature",
+    "description": "Step Functions Linter: Resource property of Task state will accept any string instead of just arn. Additional disallowed properties will be marked as invalid."
+}

package-lock.json

@@ -914,7 +914,7 @@
     },
     "dependencies": {
         "adm-zip": "^0.4.13",
-        "amazon-states-language-service": "^1.0.2",
+        "amazon-states-language-service": "^1.1.0",
         "async-lock": "^1.1.3",
         "aws-sdk": "^2.581.0",
         "cloudformation-schema-js-yaml": "^1.0.1",

package.json

@@ -30,8 +30,6 @@ export const VISUALIZATION_CSS_URL = 'https://do0of8uwbahzz.cloudfront.net/graph
 export const SCRIPTS_LAST_DOWNLOADED_URL = 'SCRIPT_LAST_DOWNLOADED_URL'
 export const CSS_LAST_DOWNLOADED_URL = 'CSS_LAST_DOWNLOADED_URL'
 
-export const ARN_REGEX_STRING = String.raw`^arn:aws([a-z]|\-)*:(states|lambda):([a-z]|\d|\-)*:([0-9]{12})?:.+:.+$`
-
 export interface UpdateCachedScriptOptions {
     globalStorage: vscode.Memento
     lastDownloadedURLKey: string
@@ -194,10 +192,7 @@ export async function isDocumentValid(textDocument?: vscode.TextDocument): Promi
     const doc = ASLTextDocument.create(textDocument.uri.path, textDocument.languageId, textDocument.version, text)
     // tslint:disable-next-line: no-inferred-empty-object-type
     const jsonDocument = languageService.parseJSONDocument(doc)
-    const diagnostics = (await languageService.doValidation(doc, jsonDocument, documentSettings))
-        // Invalid ARN strings shouldn't prevent rendering of the state machine graph
-        .filter(diagnostic => !diagnostic.message.includes(ARN_REGEX_STRING))
-
+    const diagnostics = await languageService.doValidation(doc, jsonDocument, documentSettings)
     const isValid = !diagnostics.some(diagnostic => diagnostic.severity === DiagnosticSeverity.Error)
 
     return isValid