Skip to content

Commit 2a3c71e

Browse files
authored
fix: use 99.x as alpha/beta version #4053
Problem: package.ts generates "alpha" builds using version 1.9999. This was driven by the notion that we might want all "alpha" testers to be auto-updated if we ever bump the prod major version. But in practice there is no clear demarcation where or when that happens. And it means we need to bump the "alpha" version whenever we bump the prod major version. Solution: Use 99.x for "alpha" builds. ref 991bfcb
1 parent d86136c commit 2a3c71e

File tree

3 files changed

+6
-7
lines changed

3 files changed

+6
-7
lines changed

CONTRIBUTING.md

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -455,10 +455,9 @@ There are several ways to make pre-production changes available on a "preview" o
455455
- **Beta artifacts:** For a "private beta" launch, `src/dev/beta.ts` contains
456456
logic to check a hardcoded, stable URL serving the latest `.vsix` build for
457457
the private beta. The hardcoded URL defined in [`dev/config.ts:betaUrl`](https://github.com/aws/aws-toolkit-vscode/blob/d9c27234c0732b021d07e184a865213d6efde8ec/src/dev/config.ts#L9)
458-
also forces the Toolkit to declare version `1.9999.0` (since "private beta"
459-
has no semver and would conflict with the VSCode marketplace version,
460-
causing unwanted auto-updating by VSCode). Beta builds of the Toolkit
461-
automatically query the URL once per session per day.
458+
also forces the Toolkit to declare version `99.0` (since "private beta" has no semver and to
459+
avoid unwanted auto-updating from VSCode marketplace). Beta builds of the Toolkit automatically
460+
query the URL once per session per day.
462461

463462
## Code of Conduct
464463

scripts/build/package.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
//
77
// Creates an artifact that can be given to users for testing alpha/beta builds:
88
//
9-
// aws-toolkit-vscode-1.9999.0-xxxxxxxxxxxx.vsix
9+
// aws-toolkit-vscode-99.0.0-xxxxxxxxxxxx.vsix
1010
//
1111
// Where `xxxxxxxxxxxx` is the first 12 characters of the commit hash that produced the artifact
1212
//
@@ -121,7 +121,7 @@ function main() {
121121
const versionSuffix = getVersionSuffix(args.feature)
122122
const version = packageJson.version
123123
// Setting the version to an arbitrarily high number stops VSC from auto-updating the beta extension
124-
const betaOrDebugVersion = `1.9999.0${versionSuffix}`
124+
const betaOrDebugVersion = `99.0.0${versionSuffix}`
125125
if (isBeta() || args.debug) {
126126
packageJson.version = betaOrDebugVersion
127127
} else {

src/shared/extensions.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,4 +48,4 @@ export interface ExtContext {
4848
/**
4949
* Version of the .vsix produced by package.ts with the --debug option.
5050
*/
51-
export const extensionAlphaVersion = '1.9999.0-SNAPSHOT'
51+
export const extensionAlphaVersion = '99.0.0-SNAPSHOT'

0 commit comments

Comments
 (0)