fix: help > open logs may not work after interacting with other options (#4139)

* fix: help > open logs may not work after interacting with other options

Problem: Interacting with other options in the Amazon Q and Explorer views ellipses menu can cause the
view logs option (of the same tree) to open an empty file. Since this command and menu options are
maintained in package.json only, vscode may not properly supply arguments which leads to the open logs
command breaking.

Solution: Validate input arguments to the open logs command.

* refactor: update aws.viewLog comment and syntax

Co-authored-by: Justin M. Keyes <[email protected]>

* refactor: remove unused arg to openLogs()

---------

Co-authored-by: Justin M. Keyes <[email protected]>

Author: hayemaxi

.changes/next-release/Bug Fix-402cf60e-4ce2-4886-9133-b77af3b6f42b.json

@@ -0,0 +1,4 @@
+{
+	"type": "Bug Fix",
+	"description": "Help > View Toolkit Logs opens an empty file if other menu items were interacted with first."
+}

src/shared/logger/commands.ts

@@ -28,17 +28,16 @@ export class Logging {
         viewLogsAtMessage: Commands.from(this).declareOpenLogId('aws.viewLogsAtMessage'),
     }
 
-    public constructor(private readonly defaultLogUri: vscode.Uri, private readonly logger: Logger) {}
+    public constructor(private readonly logUri: vscode.Uri, private readonly logger: Logger) {}
 
-    public async openLogUri(logUri = this.defaultLogUri): Promise<vscode.TextEditor | undefined> {
-        telemetry.toolkit_viewLogs.emit() // Perhaps add additional argument to know which log was viewed?
-
-        return vscode.window.showTextDocument(logUri)
+    public async openLogUri(): Promise<vscode.TextEditor | undefined> {
+        telemetry.toolkit_viewLogs.emit()
+        return vscode.window.showTextDocument(this.logUri)
     }
 
-    public async openLogId(logId: number, logUri = this.defaultLogUri) {
-        const msg = this.logger.getLogById(logId, logUri)
-        const editor = await this.openLogUri(logUri)
+    public async openLogId(logId: number) {
+        const msg = this.logger.getLogById(logId, this.logUri)
+        const editor = await this.openLogUri()
         if (!msg || !editor) {
             return
         }