add testing to ec2InstanceNode

Author: Hweinstock

src/ec2/explorer/ec2InstanceNode.ts

@@ -11,6 +11,10 @@ import globals from '../../shared/extensionGlobals'
 import { Ec2Selection, getIconCodeForInstanceStatus } from '../utils'
 import { Ec2ParentNode } from './ec2ParentNode'
 
+export const Ec2InstanceRunningContext = 'awsEc2RunningNode'
+export const Ec2InstanceStoppedContext = 'awsEc2StoppedNode'
+export const Ec2InstancePendingContext = 'awsEc2PendingNode'
+
 type Ec2InstanceNodeContext = 'awsEc2RunningNode' | 'awsEc2StoppedNode' | 'awsEc2PendingNode'
 
 export class Ec2InstanceNode extends AWSTreeNodeBase implements AWSResourceNode {
@@ -19,7 +23,7 @@ export class Ec2InstanceNode extends AWSTreeNodeBase implements AWSResourceNode
         public readonly client: Ec2Client,
         public override readonly regionCode: string,
         private readonly partitionId: string,
-        private instance: Ec2Instance
+        protected instance: Ec2Instance
     ) {
         super('')
         this.updateInstance(instance)
@@ -40,14 +44,14 @@ export class Ec2InstanceNode extends AWSTreeNodeBase implements AWSResourceNode
 
     private getContext(): Ec2InstanceNodeContext {
         if (this.instance.status == 'running') {
-            return 'awsEc2RunningNode'
+            return Ec2InstanceRunningContext
         }
 
         if (this.instance.status == 'stopped') {
-            return 'awsEc2StoppedNode'
+            return Ec2InstanceStoppedContext
         }
 
-        return 'awsEc2PendingNode'
+        return Ec2InstancePendingContext
     }
 
     public setInstance(newInstance: Ec2Instance) {

src/test/ec2/explorer/ec2InstanceNode.test.ts

@@ -4,7 +4,12 @@
  */
 
 import * as assert from 'assert'
-import { Ec2InstanceNode } from '../../../ec2/explorer/ec2InstanceNode'
+import {
+    Ec2InstanceNode,
+    Ec2InstancePendingContext,
+    Ec2InstanceRunningContext,
+    Ec2InstanceStoppedContext,
+} from '../../../ec2/explorer/ec2InstanceNode'
 import { Ec2Client, Ec2Instance, getNameOfInstance } from '../../../shared/clients/ec2Client'
 import { Ec2ParentNode } from '../../../ec2/explorer/ec2ParentNode'
 
@@ -16,14 +21,14 @@ describe('ec2InstanceNode', function () {
 
     before(function () {
         testInstance = {
-            InstanceId: 'testId',
+            InstanceId: 'running-testId',
             Tags: [
                 {
                     Key: 'Name',
                     Value: 'testName',
                 },
             ],
-            status: 'testing',
+            status: 'running',
         }
         const testClient = new Ec2Client('')
         const testParentNode = new Ec2ParentNode(testRegion, testPartition, testClient)
@@ -59,4 +64,18 @@ describe('ec2InstanceNode', function () {
     it('intializes the client', async function () {
         assert.ok(testNode.client instanceof Ec2Client)
     })
+
+    it('sets context value based on status', async function () {
+        const stoppedInstance = { ...testInstance, status: 'stopped' }
+        testNode.updateInstance(stoppedInstance)
+        assert.strictEqual(testNode.contextValue, Ec2InstanceStoppedContext)
+
+        const runningInstance = { ...testInstance, status: 'running' }
+        testNode.updateInstance(runningInstance)
+        assert.strictEqual(testNode.contextValue, Ec2InstanceRunningContext)
+
+        const pendingInstance = { ...testInstance, status: 'pending' }
+        testNode.updateInstance(pendingInstance)
+        assert.strictEqual(testNode.contextValue, Ec2InstancePendingContext)
+    })
 })

src/test/ec2/explorer/ec2ParentNode.test.ts

@@ -4,7 +4,7 @@
  */
 
 import * as assert from 'assert'
-import { Ec2ParentNode, parentContextValue } from '../../../ec2/explorer/ec2ParentNode'
+import { Ec2ParentNode } from '../../../ec2/explorer/ec2ParentNode'
 import { stub } from '../../utilities/stubber'
 import { Ec2Client, Ec2Instance } from '../../../shared/clients/ec2Client'
 import { intoCollection } from '../../../shared/utilities/collectionUtils'
@@ -36,8 +36,8 @@ describe('ec2ParentNode', function () {
 
     beforeEach(function () {
         instances = [
-            { name: 'firstOne', InstanceId: '0' },
-            { name: 'secondOne', InstanceId: '1' },
+            { name: 'firstOne', InstanceId: '0', status: 'running' },
+            { name: 'secondOne', InstanceId: '1', status: 'stopped' },
         ]
 
         testNode = new Ec2ParentNode(testRegion, testPartition, createClient())
@@ -61,14 +61,6 @@ describe('ec2ParentNode', function () {
         )
     })
 
-    it('has child nodes with ec2 contextValuue', async function () {
-        const childNodes = await testNode.getChildren()
-
-        childNodes.forEach(node =>
-            assert.strictEqual(node.contextValue, parentContextValue, 'expected the node to have a ec2 contextValue')
-        )
-    })
-
     it('sorts child nodes', async function () {
         const sortedText = ['aa', 'ab', 'bb', 'bc', 'cc', 'cd']
         instances = [