Skip to content

Commit 2e0e7ba

Browse files
fix(ci): latest sam cli update breaks python 3.10 integ tests #3726
sam: set explicit sam version in CI It looks like aws-sam-cli 1.95.0 is causing our python 3.10 sam tests to fail. Downgrading to the previous version to check Signed-off-by: Nikolas Komonen <[email protected]>
1 parent 2921bdd commit 2e0e7ba

File tree

2 files changed

+13
-1
lines changed

2 files changed

+13
-1
lines changed

buildspec/linuxIntegrationTests.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,8 @@ phases:
7777
fi
7878
# Where non-root "pip3 install" puts things:
7979
- 'export PATH="$HOME/.local/bin:$PATH"'
80-
- '>/dev/null pip3 install --upgrade aws-sam-cli'
80+
# Explicit older version since we assume the newer version is causing our CI to fail (python 3.10 sam tests specifically)
81+
- '>/dev/null pip install aws-sam-cli==1.94.0'
8182
- '>/dev/null pip3 install --upgrade awscli'
8283
# Print info about sam (version, location, …).
8384
- 'pip3 show aws-sam-cli'

src/test/techdebt.test.ts

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,4 +42,15 @@ describe('tech debt', function () {
4242
'with node16+, we can use crypto.randomUUID and remove the "uuid" dependency'
4343
)
4444
})
45+
46+
it('remove explicit sam cli version', function () {
47+
// Indicate to start using the latest aws-sam-cli version in our CI
48+
// https://issues.amazon.com/issues/IDE-11386
49+
const nextMonth = new Date(2023, 8, 12) // September 12th, 2023
50+
const now = new Date()
51+
assert(
52+
now < nextMonth,
53+
'Remove use of 1.94.0 for aws-sam-cli in linuxIntegrationTests.yml and see if integration tests are passing now'
54+
)
55+
})
4556
})

0 commit comments

Comments
 (0)