ec2: expose connect to instance command on explorer node. (#3625)

Problem:
Currently the explorer doesn't have any functionality. It is purely visual.

Solution:
Expose the connect to instance command on right click of an explorer node.

Author: Hweinstock

package.json

@@ -1308,6 +1308,11 @@
                     "when": "viewItem == awsCodeCatalystNodeSaved",
                     "group": "inline@1"
                 },
+                {
+                    "command": "aws.ec2.connectToInstance",
+                    "group": "0@1",
+                    "when": "viewItem == awsEc2Node"
+                },
                 {
                     "command": "aws.ecr.createRepository",
                     "when": "view == aws.explorer && viewItem == awsEcrNode",

src/ec2/activation.ts

@@ -6,13 +6,14 @@ import { ExtContext } from '../shared/extensions'
 import { Commands } from '../shared/vscode/commands2'
 import { tryConnect } from './commands'
 import { telemetry } from '../shared/telemetry/telemetry'
+import { Ec2InstanceNode } from './explorer/ec2InstanceNode'
 
 export async function activate(ctx: ExtContext): Promise<void> {
     ctx.extensionContext.subscriptions.push(
-        Commands.register('aws.ec2.connectToInstance', async (param?: unknown) => {
+        Commands.register('aws.ec2.connectToInstance', async (node?: Ec2InstanceNode) => {
             await telemetry.ec2_connectToInstance.run(async span => {
                 span.record({ ec2ConnectionType: 'ssm' })
-                await tryConnect()
+                await (node ? tryConnect(node.toSelection()) : tryConnect())
             })
         })
     )

src/ec2/commands.ts

@@ -6,17 +6,27 @@
 import { createEc2ConnectPrompter, handleEc2ConnectPrompterResponse } from './prompter'
 import { isValidResponse } from '../shared/wizards/wizard'
 import { Ec2ConnectionManager } from './model'
+import { Ec2Selection } from './utils'
+import { RegionSubmenuResponse } from '../shared/ui/common/regionSubmenu'
+import { PromptResult } from '../shared/ui/prompter'
 import { CancellationError } from '../shared/utilities/timeoutUtils'
 
-export async function tryConnect(): Promise<void> {
-    const prompter = createEc2ConnectPrompter()
-    const response = await prompter.prompt()
-
+function getSelectionFromResponse(response: PromptResult<RegionSubmenuResponse<string>>): Ec2Selection {
     if (isValidResponse(response)) {
-        const selection = handleEc2ConnectPrompterResponse(response)
-        const ec2Client = new Ec2ConnectionManager(selection.region)
-        await ec2Client.attemptEc2Connection(selection)
+        return handleEc2ConnectPrompterResponse(response)
     } else {
         throw new CancellationError('user')
     }
 }
+
+export async function tryConnect(selection?: Ec2Selection): Promise<void> {
+    if (!selection) {
+        const prompter = createEc2ConnectPrompter()
+        const response = await prompter.prompt()
+
+        selection = getSelectionFromResponse(response)
+    }
+
+    const ec2Client = new Ec2ConnectionManager(selection.region)
+    await ec2Client.attemptEc2Connection(selection)
+}

src/ec2/explorer/ec2InstanceNode.ts

@@ -9,6 +9,7 @@ import { AWSTreeNodeBase } from '../../shared/treeview/nodes/awsTreeNodeBase'
 import { Ec2Instance } from '../../shared/clients/ec2Client'
 import { build } from '@aws-sdk/util-arn-parser'
 import globals from '../../shared/extensionGlobals'
+import { Ec2Selection } from '../utils'
 
 export class Ec2InstanceNode extends AWSTreeNodeBase implements AWSResourceNode {
     public constructor(
@@ -31,6 +32,13 @@ export class Ec2InstanceNode extends AWSTreeNodeBase implements AWSResourceNode
         this.instance = newInstance
     }
 
+    public toSelection(): Ec2Selection {
+        return {
+            region: this.regionCode,
+            instanceId: this.InstanceId,
+        }
+    }
+
     public get name(): string {
         return getNameOfInstance(this.instance) ?? 'Unnamed instance'
     }