Skip to content

Commit 2fb0926

Browse files
authored
telemetry(lambda): nit to use sessionDuration correctly for debug duration (#7728)
## Problem This change has no customer facing impact. duration -> sessionDuration (correct) Previously this metrics is wrongly recorded to duration and got overwritten by the metrics wrapper ## Solution Change to use sessionDuration correctly --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
1 parent ff9d816 commit 2fb0926

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

packages/core/src/lambda/remoteDebugging/ldkController.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -729,7 +729,8 @@ export class RemoteDebugController {
729729
)
730730
return
731731
}
732-
span.record({ duration: this.lastDebugStartTime === 0 ? 0 : Date.now() - this.lastDebugStartTime })
732+
// use sessionDuration to record debug duration
733+
span.record({ sessionDuration: this.lastDebugStartTime === 0 ? 0 : Date.now() - this.lastDebugStartTime })
733734
try {
734735
await vscode.window.withProgress(
735736
{

0 commit comments

Comments
 (0)