fix(sagemaker): Show error message when trying to connect remotely from remote workspace (#2158)

## Problem
When a user is connected to a remote workspace and clicks the Open
Remote Connection button, they see an error message about the Remote SSH
extension not being installed, when the real reason is that they cannot
connect remotely from a remote workspace.

## Solution
Show an error message which states clearly that they cannot connect via
deeplink when in a remote workspace.

---

- Treat all work as PUBLIC. Private `feature/x` branches will not be
squash-merged at release time.
- Your code changes must meet the guidelines in
[CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines).
- License: I confirm that my contribution is made under the terms of the
Apache 2.0 license.

---------

Co-authored-by: Newton Der <[email protected]>

Author: NewtonDer

packages/core/src/awsService/sagemaker/commands.ts

@@ -18,7 +18,8 @@ import { ExtContext } from '../../shared/extensions'
 import { SagemakerClient } from '../../shared/clients/sagemaker'
 import { ToolkitError } from '../../shared/errors'
 import { showConfirmationMessage } from '../../shared/utilities/messages'
-import { InstanceTypeError } from './constants'
+import { RemoteSessionError } from '../../shared/remoteSession'
+import { ConnectFromRemoteWorkspaceMessage, InstanceTypeError } from './constants'
 
 const localize = nls.loadMessageBundle()
 
@@ -91,34 +92,36 @@ export async function deeplinkConnect(
     )
 
     if (isRemoteWorkspace()) {
-        void vscode.window.showErrorMessage(
-            'You are in a remote workspace, skipping deeplink connect. Please open from a local workspace.'
-        )
+        void vscode.window.showErrorMessage(ConnectFromRemoteWorkspaceMessage)
         return
     }
 
-    const remoteEnv = await prepareDevEnvConnection(
-        connectionIdentifier,
-        ctx.extensionContext,
-        'sm_dl',
-        session,
-        wsUrl,
-        token,
-        domain
-    )
-
     try {
+        const remoteEnv = await prepareDevEnvConnection(
+            connectionIdentifier,
+            ctx.extensionContext,
+            'sm_dl',
+            session,
+            wsUrl,
+            token,
+            domain
+        )
+
         await startVscodeRemote(
             remoteEnv.SessionProcess,
             remoteEnv.hostname,
             '/home/sagemaker-user',
             remoteEnv.vscPath,
             'sagemaker-user'
         )
-    } catch (err) {
+    } catch (err: any) {
         getLogger().error(
             `sm:OpenRemoteConnect: Unable to connect to target space with arn: ${connectionIdentifier} error: ${err}`
         )
+
+        if (![RemoteSessionError.MissingExtension, RemoteSessionError.ExtensionVersionTooLow].includes(err.code)) {
+            throw err
+        }
     }
 }
 
@@ -157,6 +160,11 @@ export async function stopSpace(node: SagemakerSpaceNode, ctx: vscode.ExtensionC
 }
 
 export async function openRemoteConnect(node: SagemakerSpaceNode, ctx: vscode.ExtensionContext) {
+    if (isRemoteWorkspace()) {
+        void vscode.window.showErrorMessage(ConnectFromRemoteWorkspaceMessage)
+        return
+    }
+
     if (node.getStatus() === 'Stopped') {
         const client = new SagemakerClient(node.regionCode)
 

packages/core/src/awsService/sagemaker/constants.ts

@@ -3,6 +3,9 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
+export const ConnectFromRemoteWorkspaceMessage =
+    'Unable to establish new remote connection. Your last active VS Code window is connected to a remote workspace. To open a new SageMaker Studio connection, select your local VS Code window and try again.'
+
 export const InstanceTypeError = 'InstanceTypeError'
 
 export const InstanceTypeMinimum = 'ml.t3.large'

packages/core/src/shared/remoteSession.ts

@@ -25,6 +25,11 @@ import { EvaluationResult } from '@aws-sdk/client-iam'
 
 const policyAttachDelay = 5000
 
+export enum RemoteSessionError {
+    ExtensionVersionTooLow = 'ExtensionVersionTooLow',
+    MissingExtension = 'MissingExtension',
+}
+
 export interface MissingTool {
     readonly name: 'code' | 'ssm' | 'ssh'
     readonly reason?: string
@@ -114,13 +119,13 @@ export async function ensureRemoteSshInstalled(): Promise<void> {
         if (isExtensionInstalled(VSCODE_EXTENSION_ID.remotessh)) {
             throw new ToolkitError('Remote SSH extension version is too low', {
                 cancelled: true,
-                code: 'ExtensionVersionTooLow',
+                code: RemoteSessionError.ExtensionVersionTooLow,
                 details: { expected: vscodeExtensionMinVersion.remotessh },
             })
         } else {
             throw new ToolkitError('Remote SSH extension not installed', {
                 cancelled: true,
-                code: 'MissingExtension',
+                code: RemoteSessionError.MissingExtension,
             })
         }
     }