revert --no-sandbox

Author: justinmk3

scripts/test/launchTestUtilities.ts

@@ -49,10 +49,7 @@ export async function setupVSCodeTestInstance(): Promise<string> {
 
 export async function invokeVSCodeCli(vsCodeExecutablePath: string, args: string[]): Promise<string> {
     const [cli, ...cliArgs] = resolveCliArgsFromVSCodeExecutablePath(vsCodeExecutablePath)
-    // Disable sandbox to avoid: "Running as root without --no-sandbox is not supported".
-    // https://github.com/aws/aws-toolkit-vscode/issues/3550
-    // https://crbug.com/638180
-    const cmdArgs = ['--no-sandbox', ...cliArgs, ...args]
+    const cmdArgs = [...cliArgs, ...args]
 
     // Workaround: set --user-data-dir to avoid this error in CI:
     // "You are trying to start Visual Studio Code as a super user …"
@@ -133,11 +130,6 @@ async function setupVSCode(): Promise<string> {
 }
 
 export async function runToolkitTests(suiteName: string, relativeEntryPoint: string) {
-    // Disable sandbox to avoid: "Running as root without --no-sandbox is not supported".
-    // https://github.com/aws/aws-toolkit-vscode/issues/3550
-    // https://crbug.com/638180
-    const noSandboxArgs = ['--no-sandbox', '--disable-gpu-sandbox']
-
     try {
         console.log(`Running ${suiteName} test suite...`)
         const vsCodeExecutablePath = await setupVSCode()
@@ -162,7 +154,7 @@ export async function runToolkitTests(suiteName: string, relativeEntryPoint: str
             vscodeExecutablePath: vsCodeExecutablePath,
             extensionDevelopmentPath: cwd,
             extensionTestsPath: testEntrypoint,
-            launchArgs: [...noSandboxArgs, ...disableExtensions, workspacePath, disableWorkspaceTrust],
+            launchArgs: [...disableExtensions, workspacePath, disableWorkspaceTrust],
             extensionTestsEnv: {
                 ['DEVELOPMENT_PATH']: cwd,
                 ['AWS_TOOLKIT_AUTOMATION']: suiteName,

scripts/test/test.ts

@@ -21,7 +21,7 @@ import { setupVSCodeTestInstance } from './launchTestUtilities'
             extensionDevelopmentPath: rootDir,
             extensionTestsPath: testEntrypoint,
             // For verbose VSCode logs, add "--verbose --log debug". c2165cf48e62c
-            launchArgs: ['--no-sandbox', '--disable-gpu-sandbox', testWorkspace],
+            launchArgs: [testWorkspace],
             extensionTestsEnv: {
                 ['DEVELOPMENT_PATH']: rootDir,
                 ['AWS_TOOLKIT_AUTOMATION']: 'unit',