build: require minimum NPM version #3959

Problem:
Developers may have outdated tooling, which causes weird problems.

Solution:
- Define minimum npm version and enforce it via `.npmrc`. Outdated npm will show an error like:
  ```
  $ npm install
  npm ERR! code EBADENGINE
  npm ERR! engine Unsupported engine
  npm ERR! engine Not compatible with your version of node/npm: [email protected]
  npm ERR! notsup Not compatible with your version of node/npm: [email protected]
  npm ERR! notsup Required: {"npm":"^10.1.0","vscode":"^1.68.0"}
  npm ERR! notsup Actual:   {"npm":"10.0.0","node":"v20.8.0"}
  ```
- Disable the check in CI. Because it's transitive, random dependencies
  like "marked" can pointlessly require aggressively-recent versions of
  NPM, which isn't feasible for us to support in our CI:
  ```
  npm ERR! engine Not compatible with your version of node/npm: [email protected]
  npm ERR! notsup Not compatible with your version of node/npm: [email protected]
  npm ERR! notsup Required: {"node":">= 18"}
  npm ERR! notsup Actual:   {"npm":"8.19.4","node":"v16.20.2"}
  ```

Author: justinmk3

.github/workflows/node.js.yml

@@ -23,6 +23,8 @@ jobs:
             NODE_OPTIONS: '--max-old-space-size=8192'
         steps:
             - uses: actions/checkout@v4
+            - name: Disable engine-strict check
+              run: sed -i -e 's/engine.strict.true/engine-strict=false/' .npmrc
             - name: Use Node.js ${{ matrix.node-version }}
               uses: actions/setup-node@v4
               with:
@@ -65,6 +67,8 @@ jobs:
             NODE_OPTIONS: '--max-old-space-size=8192'
         steps:
             - uses: actions/checkout@v4
+            - name: Disable engine-strict check
+              run: sed -i -e 's/engine.strict.true/engine-strict=false/' .npmrc
             - name: Use Node.js ${{ matrix.node-version }}
               uses: actions/setup-node@v4
               with:
@@ -94,6 +98,8 @@ jobs:
             NODE_OPTIONS: '--max-old-space-size=8192'
         steps:
             - uses: actions/checkout@v4
+            - name: Disable engine-strict check
+              run: sed -i -e 's/engine.strict.true/engine-strict=false/' .npmrc
             - name: Use Node.js ${{ matrix.node-version }}
               uses: actions/setup-node@v4
               with:

.npmrc

@@ -0,0 +1 @@
+engine-strict=true

buildspec/linuxE2ETests.yml

@@ -20,6 +20,8 @@ phases:
 
     build:
         commands:
+            # Disable engine-strict in CI.
+            - sed -i -e 's/engine.strict.true/engine-strict=false/' .npmrc
             - npm ci --unsafe-perm
             # We cannot run `code` as root during tests
             # From: https://github.com/aws/aws-codebuild-docker-images/blob/2f796bb9c81fcfbc8585832b99a5f780ae2b2f52/ubuntu/standard/6.0/Dockerfile#L56

buildspec/linuxIntegrationTests.yml

@@ -22,6 +22,8 @@ phases:
             java: latest
 
         commands:
+            # Disable engine-strict in CI.
+            - sed -i -e 's/engine.strict.true/engine-strict=false/' .npmrc
             - '>/dev/null add-apt-repository universe'
             - '>/dev/null apt-get -qq install -y apt-transport-https'
             - '>/dev/null apt-get -qq update'

buildspec/linuxTests.yml

@@ -13,6 +13,8 @@ phases:
         runtime-versions:
             nodejs: 16
         commands:
+            # Disable engine-strict in CI.
+            - sed -i -e 's/engine.strict.true/engine-strict=false/' .npmrc
             # Without this, "Unable to locate package libatk1.0-0".
             - '>/dev/null apt-get -yqq update'
             # Dependencies for running vscode.

buildspec/packageTestVsix.yml

@@ -15,6 +15,8 @@ phases:
         runtime-versions:
             nodejs: 16
         commands:
+            # Disable engine-strict in CI.
+            - sed -i -e 's/engine.strict.true/engine-strict=false/' .npmrc
             # Prepare env for unprivileged user.
             - |
                 mkdir -p ~codebuild-user

package-lock.json

@@ -13,6 +13,7 @@
         "url": "https://github.com/aws/aws-toolkit-vscode"
     },
     "engines": {
+        "npm": "^10.1.0",
         "vscode": "^1.68.0"
     },
     "icon": "resources/marketplace/aws-icon-256x256.png",