lint

Author: justinmk3

src/shared/sam/cli/samCliLocator.ts

@@ -34,12 +34,13 @@ export class DefaultSamCliLocationProvider implements SamCliLocationProvider {
         const cachedLoc = DefaultSamCliLocationProvider.cachedSamLocation
 
         // Avoid searching the system for `sam` (especially slow on Windows).
-        if (cachedLoc && await DefaultSamCliLocationProvider.isValidSamLocation(cachedLoc.path)) {
+        if (cachedLoc && (await DefaultSamCliLocationProvider.isValidSamLocation(cachedLoc.path))) {
             perflog.done()
             return cachedLoc
         }
 
-        DefaultSamCliLocationProvider.cachedSamLocation = await DefaultSamCliLocationProvider.getSamCliLocator().getLocation()
+        DefaultSamCliLocationProvider.cachedSamLocation =
+            await DefaultSamCliLocationProvider.getSamCliLocator().getLocation()
         perflog.done()
         return DefaultSamCliLocationProvider.cachedSamLocation
     }
@@ -105,7 +106,9 @@ abstract class BaseSamCliLocator {
                         BaseSamCliLocator.didFind = true
                         return { path: fullPath, version: validationResult.version }
                     }
-                    this.logger.warn(`samCliLocator: found invalid SAM CLI: (${validationResult.validation}): ${fullPath}`)
+                    this.logger.warn(
+                        `samCliLocator: found invalid SAM CLI: (${validationResult.validation}): ${fullPath}`
+                    )
                 } catch (e) {
                     const err = e as Error
                     this.logger.error('samCliLocator failed: %s', err.message)

src/shared/systemUtilities.ts

@@ -192,7 +192,12 @@ export class SystemUtilities {
      * @param doLog log failures
      * @param expected output must contain this string
      */
-    public static async tryRun(p: string, args: string[], logging: 'yes' | 'no' | 'noresult' = 'yes', expected?: string): Promise<boolean> {
+    public static async tryRun(
+        p: string,
+        args: string[],
+        logging: 'yes' | 'no' | 'noresult' = 'yes',
+        expected?: string
+    ): Promise<boolean> {
         const proc = new ChildProcess(p, args, { logging: 'no' })
         const r = await proc.run()
         const ok = r.exitCode === 0 && (expected === undefined || r.stdout.includes(expected))

src/shared/utilities/asyncCollection.ts

@@ -222,11 +222,11 @@ async function promise<T>(iterable: AsyncIterable<T>): Promise<T[]> {
 function addToMap<T, U extends string>(map: Map<string, T>, selector: KeySelector<T, U> | StringProperty<T>, item: T) {
     const key = typeof selector === 'function' ? selector(item) : item[selector]
     if (key) {
-        if (map.has(key as keyof typeof map['keys'])) {
+        if (map.has(key as keyof (typeof map)['keys'])) {
             throw new Error(`Duplicate key found when converting AsyncIterable to map: ${key}`)
         }
 
-        map.set(key as keyof typeof map['keys'], item)
+        map.set(key as keyof (typeof map)['keys'], item)
     }
 }
 

src/shared/utilities/functionUtils.ts

@@ -56,9 +56,10 @@ export function onceChanged<T, U extends any[]>(fn: (...args: U) => T): (...args
     let ran = false
     let prevArgs = ''
 
-    return (...args) => ((ran && prevArgs === args.map(String).join(':'))
-        ? val
-        : ((val = fn(...args)), (ran = true), (prevArgs = args.map(String).join(':')), val))
+    return (...args) =>
+        ran && prevArgs === args.map(String).join(':')
+            ? val
+            : ((val = fn(...args)), (ran = true), (prevArgs = args.map(String).join(':')), val)
 }
 
 /**

src/shared/utilities/typeConstructors.ts

@@ -51,7 +51,7 @@ export type FromDescriptor<T extends TypeDescriptor> = {
 
 // `Symbol` and `BigInt` are included here, though in-practice
 const primitives = [Number, String, Boolean, Object, Symbol, BigInt]
-function isPrimitiveConstructor(type: unknown): type is typeof primitives[number] {
+function isPrimitiveConstructor(type: unknown): type is (typeof primitives)[number] {
     return !!primitives.find(p => p === type)
 }
 

src/stepFunctions/activation.ts

@@ -88,7 +88,9 @@ async function registerStepFunctionCommands(
     )
 }
 
-export function initalizeWebviewPaths(context: vscode.ExtensionContext): typeof globals['visualizationResourcePaths'] {
+export function initalizeWebviewPaths(
+    context: vscode.ExtensionContext
+): (typeof globals)['visualizationResourcePaths'] {
     // Location for script in body of webview that handles input from user
     // and calls the code to render state machine graph
 

src/test/shared/sam/cli/samCliTestUtils.ts

@@ -21,9 +21,9 @@ export class MockSamCliProcessInvoker implements SamCliProcessInvoker {
 
         this.validateArgs(invokeSettings.arguments)
 
-        return ({
+        return {
             exitCode: 0,
-        } as any) as ChildProcessResult
+        } as any as ChildProcessResult
     }
 }