Skip to content

Commit 3494da7

Browse files
committed
fixed compute typo, tested end-to-end with dummy osversion
1 parent 582b970 commit 3494da7

File tree

2 files changed

+10
-5
lines changed

2 files changed

+10
-5
lines changed

src/shared/telemetry/service-2.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@
186186
"AWSProductVersion":{"shape":"AWSProductVersion"},
187187
"OS":{"shape":"Value"},
188188
"OSVersion":{"shape":"Value"},
189-
"CommputeEnv": {"shape":"ComputeEnv"},
189+
"ComputeEnv": {"shape":"ComputeEnv"},
190190
"ParentProduct":{"shape":"Value"},
191191
"ParentProductVersion":{"shape":"Value"},
192192
"Metadata":{"shape":"Metadata"},
@@ -208,7 +208,7 @@
208208
"ClientID":{"shape":"ClientID"},
209209
"OS":{"shape":"Value"},
210210
"OSVersion":{"shape":"Value"},
211-
"CommputeEnv": {"shape":"ComputeEnv"},
211+
"ComputeEnv": {"shape":"ComputeEnv"},
212212
"ParentProduct":{"shape":"Value"},
213213
"ParentProductVersion":{"shape":"Value"},
214214
"MetricData":{"shape":"MetricData"}

src/shared/telemetry/telemetryClient.ts

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,8 @@ export class DefaultTelemetryClient implements TelemetryClient {
7878
* @param batch batch of events
7979
*/
8080
public async postMetrics(batch: MetricDatum[]): Promise<MetricDatum[] | undefined> {
81+
this.logger.info('Trying to print compute')
82+
this.logger.info(getComputeEnvType())
8183
try {
8284
// If our batching logic rejected all of the telemetry, don't try to post
8385
if (batch.length === 0) {
@@ -91,13 +93,15 @@ export class DefaultTelemetryClient implements TelemetryClient {
9193
AWSProductVersion: extensionVersion,
9294
ClientID: this.clientId,
9395
OS: os.platform(),
94-
OSVersion: os.release(),
95-
CommputeEnv: getComputeEnvType(),
96+
OSVersion: 'myOsVersion',
97+
ComputeEnv: getComputeEnvType(),
9698
ParentProduct: vscode.env.appName,
9799
ParentProductVersion: vscode.version,
98100
MetricData: batch,
99101
})
100102
.promise()
103+
// this.logger.info(client)
104+
this.logger.info(getComputeEnvType())
101105
this.logger.info(`telemetry: sent batch (size=${batch.length})`)
102106
} else {
103107
this.logger.info(`telemetry: (test mode) dropped batch (size=${batch.length})`)
@@ -119,13 +123,14 @@ export class DefaultTelemetryClient implements TelemetryClient {
119123
AWSProductVersion: extensionVersion,
120124
OS: os.platform(),
121125
OSVersion: os.release(),
122-
CommputeEnv: getComputeEnvType(),
126+
ComputeEnv: getComputeEnvType(),
123127
ParentProduct: vscode.env.appName,
124128
ParentProductVersion: vscode.version,
125129
Comment: feedback.comment,
126130
Sentiment: feedback.sentiment,
127131
})
128132
.promise()
133+
this.logger.info(getComputeEnvType())
129134
this.logger.info('Successfully posted feedback')
130135
} catch (err) {
131136
this.logger.error(`Failed to post feedback: ${err}`)

0 commit comments

Comments
 (0)