Skip to content

Commit 354164a

Browse files
committed
wrap entire check in a waitUntil
1 parent a5225f9 commit 354164a

File tree

1 file changed

+7
-9
lines changed

1 file changed

+7
-9
lines changed

packages/core/src/test/credentials/auth.test.ts

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ import { getCredentialsFilename } from '../../auth/credentials/sharedCredentials
2020
import { Connection, isIamConnection, isSsoConnection, scopesSsoAccountAccess } from '../../auth/connection'
2121
import { AuthNode, createDeleteConnectionButton, promptForConnection } from '../../auth/utils'
2222
import { waitUntil } from '../../shared'
23+
import { Credentials } from '@aws-sdk/types'
2324

2425
const ssoProfile = createSsoProfile()
2526
const scopedSsoProfile = createSsoProfile({ scopes: ['foo'] })
@@ -524,26 +525,23 @@ describe('Auth', function () {
524525
sessionToken: undefined,
525526
})
526527
const contentBefore = await fs.readFileText(getCredentialsFilename())
527-
const statBefore = await fs.stat(getCredentialsFilename())
528528
await fs.delete(getCredentialsFilename())
529529
const newCreds = { ...initialCreds, accessKey: 'y', secretKey: 'y' }
530530
await UserCredentialsUtils.generateCredentialsFile(newCreds)
531531
const contentAfter = await fs.readFileText(getCredentialsFilename())
532532

533533
assert.notDeepStrictEqual(contentBefore, contentAfter)
534534

535-
const updated = await waitUntil(async () => statBefore !== (await fs.stat(getCredentialsFilename())), {
535+
const areCredsEqual = (creds: Credentials) => {
536+
return creds.accessKeyId === newCreds.accessKey && creds.secretAccessKey === newCreds.secretKey
537+
}
538+
539+
const credsUpdated = await waitUntil(async () => areCredsEqual(await conn.getCredentials()), {
536540
timeout: 20000,
537541
interval: 1000,
538542
truthy: true,
539543
})
540-
assert.ok(updated, 'Credentials file update failed')
541-
542-
assert.deepStrictEqual(await conn.getCredentials(), {
543-
accessKeyId: newCreds.accessKey,
544-
secretAccessKey: newCreds.secretKey,
545-
sessionToken: undefined,
546-
})
544+
assert.ok(credsUpdated, 'Credentials file update failed')
547545
})
548546
}
549547
})

0 commit comments

Comments
 (0)