feat(runtimes): nodejs18.x #2958

Author: justinmk3

.changes/next-release/Feature-19ec072b-c7af-4361-9db5-de896ea867d3.json

@@ -0,0 +1,4 @@
+{
+	"type": "Feature",
+	"description": "SAM: create, run and debug nodejs18.x Lambdas"
+}

src/integrationTest/sam.test.ts

@@ -59,27 +59,27 @@ interface TestScenario {
 const scenarios: TestScenario[] = [
     // zips
     {
-        runtime: 'nodejs12.x',
-        displayName: 'nodejs12.x (ZIP)',
+        runtime: 'nodejs14.x',
+        displayName: 'nodejs14.x (ZIP)',
         path: 'hello-world/app.js',
         debugSessionType: 'pwa-node',
         language: 'javascript',
         dependencyManager: 'npm',
         vscodeMinimum: '1.50.0',
     },
     {
-        runtime: 'nodejs14.x',
-        displayName: 'nodejs14.x (ZIP)',
+        runtime: 'nodejs16.x',
+        displayName: 'nodejs16.x (ZIP)',
         path: 'hello-world/app.js',
         debugSessionType: 'pwa-node',
         language: 'javascript',
         dependencyManager: 'npm',
         vscodeMinimum: '1.50.0',
     },
     {
-        runtime: 'nodejs16.x',
-        displayName: 'nodejs16.x (ZIP)',
-        path: 'hello-world/app.js',
+        runtime: 'nodejs18.x',
+        displayName: 'nodejs18.x (ZIP)',
+        path: 'hello-world/app.mjs',
         debugSessionType: 'pwa-node',
         language: 'javascript',
         dependencyManager: 'npm',
@@ -152,16 +152,6 @@ const scenarios: TestScenario[] = [
     // { runtime: 'dotnetcore3.1', path: 'src/HelloWorld/Function.cs', debugSessionType: 'coreclr', language: 'csharp' },
 
     // images
-    {
-        runtime: 'nodejs12.x',
-        displayName: 'nodejs12.x (Image)',
-        baseImage: `amazon/nodejs12.x-base`,
-        path: 'hello-world/app.js',
-        debugSessionType: 'pwa-node',
-        language: 'javascript',
-        dependencyManager: 'npm',
-        vscodeMinimum: '1.50.0',
-    },
     {
         runtime: 'nodejs14.x',
         displayName: 'nodejs14.x (Image)',
@@ -182,6 +172,16 @@ const scenarios: TestScenario[] = [
         dependencyManager: 'npm',
         vscodeMinimum: '1.50.0',
     },
+    {
+        runtime: 'nodejs18.x',
+        displayName: 'nodejs18.x (Image)',
+        baseImage: `amazon/nodejs18.x-base`,
+        path: 'hello-world/app.mjs',
+        debugSessionType: 'pwa-node',
+        language: 'javascript',
+        dependencyManager: 'npm',
+        vscodeMinimum: '1.50.0',
+    },
     {
         runtime: 'python3.7',
         displayName: 'python3.7 (Image)',

src/lambda/models/samLambdaRuntime.ts

@@ -27,7 +27,12 @@ export type RuntimePackageType = 'Image' | 'Zip'
 
 // TODO: Consolidate all of the runtime constructs into a single <Runtime, Set<Runtime>> map
 //       We should be able to eliminate a fair amount of redundancy with that.
-export const nodeJsRuntimes: ImmutableSet<Runtime> = ImmutableSet<Runtime>(['nodejs16.x', 'nodejs14.x', 'nodejs12.x'])
+export const nodeJsRuntimes: ImmutableSet<Runtime> = ImmutableSet<Runtime>([
+    'nodejs18.x',
+    'nodejs16.x',
+    'nodejs14.x',
+    'nodejs12.x',
+])
 export const pythonRuntimes: ImmutableSet<Runtime> = ImmutableSet<Runtime>(['python3.9', 'python3.8', 'python3.7'])
 export const goRuntimes: ImmutableSet<Runtime> = ImmutableSet<Runtime>(['go1.x'])
 export const javaRuntimes: ImmutableSet<Runtime> = ImmutableSet<Runtime>(['java11', 'java8', 'java8.al2'])
@@ -69,6 +74,7 @@ export const samZipLambdaRuntimes: ImmutableSet<Runtime> = ImmutableSet.union([
 export const samArmLambdaRuntimes: ImmutableSet<Runtime> = ImmutableSet<Runtime>([
     'python3.9',
     'python3.8',
+    'nodejs18.x',
     'nodejs16.x',
     'nodejs14.x',
     'nodejs12.x',

src/test/lambda/models/samLambdaRuntime.test.ts

@@ -70,6 +70,7 @@ describe('runtimes', function () {
             'nodejs12.x',
             'nodejs14.x',
             'nodejs16.x',
+            'nodejs18.x',
             'python3.7',
             'python3.8',
             'python3.9',
@@ -78,6 +79,7 @@ describe('runtimes', function () {
             'nodejs12.x',
             'nodejs14.x',
             'nodejs16.x',
+            'nodejs18.x',
             'python3.7',
             'python3.8',
             'python3.9',
@@ -94,6 +96,7 @@ describe('runtimes', function () {
             'nodejs12.x',
             'nodejs14.x',
             'nodejs16.x',
+            'nodejs18.x',
             'python3.7',
             'python3.8',
             'python3.9',
@@ -109,6 +112,7 @@ describe('runtimes', function () {
             'nodejs12.x',
             'nodejs14.x',
             'nodejs16.x',
+            'nodejs18.x',
             'python3.7',
             'python3.8',
             'python3.9',