redshift: fix notebook connection wizard prompter order (#1077)

redshift: fix notebook connection wizard prompter order (#1077)
Problem
Temporary credentials authentication is not supported for serverless workgroups. In notebook connection wizard, connection type selection is before the cluster/workgroup selection. So it's possible for customers to select temporary credentials for serverless workgroups. Customers will get an error while executing queries.
Solution
Move the connection type selection after the cluster/warehouse selection. So temporary credentials is not available to pick for serverless workgroups.

Author: yi-jin-0

src/redshift/wizards/connectionWizard.ts

@@ -122,7 +122,7 @@ export class NotebookConnectionWizard extends Wizard<ConnectionParams> {
             }
         })
         this.form.connectionType.bindPrompter(state => getConnectionTypePrompterNB(state?.warehouseType), {
-            relativeOrder: 1,
+            relativeOrder: 3,
         })
 
         this.form.database.bindPrompter(getDatabasePrompter, { relativeOrder: 4 })

src/test/redshift/wizards/connectionWizard.test.ts

@@ -81,7 +81,7 @@ describe('NotebookConnectionWizard', async () => {
         const testWizard = createWizardTester(new NotebookConnectionWizard(mockRegionProvider))
         testWizard.region.assertShowFirst()
         testWizard.region.applyInput({ id: 'US East - 1', name: 'us-east-1' })
-        testWizard.warehouseIdentifier.assertShowSecond()
+        testWizard.warehouseIdentifier.assertShowFirst()
         testWizard.warehouseIdentifier.applyInput('testCluster')
         testWizard.connectionType.assertShowFirst()
         testWizard.connectionType.applyInput(ConnectionType.TempCreds)
@@ -96,7 +96,7 @@ describe('NotebookConnectionWizard', async () => {
         const testWizard = createWizardTester(new NotebookConnectionWizard(mockRegionProvider))
         testWizard.region.assertShowFirst()
         testWizard.region.applyInput({ id: 'US East - 1', name: 'us-east-1' })
-        testWizard.warehouseIdentifier.assertShowSecond()
+        testWizard.warehouseIdentifier.assertShowFirst()
         testWizard.warehouseIdentifier.applyInput('testCluster')
         testWizard.connectionType.assertShowFirst()
         testWizard.connectionType.applyInput(ConnectionType.SecretsManager)