Skip to content

Commit 39a42bd

Browse files
committed
docs: document yaml.ts performance risk
1 parent 6ca96e0 commit 39a42bd

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

src/shared/extensions/yaml.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,8 @@ export async function activateYamlExtension(): Promise<YamlExtension | undefined
5050
},
5151
uri => {
5252
try {
53+
// SLOW: This request happens on every keystroke! (5MB+ read from filesystem).
54+
// This is a design flaw in this registerContributor() API.
5355
return readFileSync(vscode.Uri.parse(uri).fsPath).toString()
5456
} catch (e) {
5557
getLogger().error(`YAML Extension: failed to read schema URI "${uri}": ${e}`)

0 commit comments

Comments
 (0)